Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Unified Diff: content/common/android/sync_compositor_messages.h

Issue 1846653003: android webview: Keep zoom methods synchronous (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ipc comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/android/sync_compositor_messages.h
diff --git a/content/common/android/sync_compositor_messages.h b/content/common/android/sync_compositor_messages.h
index 2e9af1a9c768725949ee63e37c298c3291518f9c..d4556dab188f081a117d27e673b2383727a48ad3 100644
--- a/content/common/android/sync_compositor_messages.h
+++ b/content/common/android/sync_compositor_messages.h
@@ -139,6 +139,8 @@ IPC_STRUCT_TRAITS_BEGIN(content::SyncCompositorCommonRendererParams)
IPC_STRUCT_TRAITS_END()
// Messages sent from the browser to the renderer.
+// Synchronous IPCs are allowed here to the renderer compositor thread. See
+// design doc https://goo.gl/Tn81FW and crbug.com/526842 for details.
IPC_SYNC_MESSAGE_ROUTED2_2(SyncCompositorMsg_HandleInputEvent,
content::SyncCompositorCommonBrowserParams,
@@ -180,6 +182,13 @@ IPC_SYNC_MESSAGE_ROUTED2_3(SyncCompositorMsg_DemandDrawSw,
IPC_MESSAGE_ROUTED1(SyncCompositorMsg_UpdateState,
content::SyncCompositorCommonBrowserParams)
+// The synchronous version is used to synchronize state from an earlier
+// asynchronous call only. This should be needed rarely so should prefer the
+// asynchronous version above in general.
+IPC_SYNC_MESSAGE_ROUTED1_1(SyncCompositorMsg_SynchronousUpdateState,
+ content::SyncCompositorCommonBrowserParams,
+ content::SyncCompositorCommonRendererParams)
+
// -----------------------------------------------------------------------------
// Messages sent from the renderer to the browser.
« no previous file with comments | « content/browser/android/synchronous_compositor_host.cc ('k') | content/public/browser/android/synchronous_compositor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698