android_webview/java/src/org/chromium/android_webview/AwContents.java - Issue 1846653003: android webview: Keep zoom methods synchronous

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 1846653003: android webview: Keep zoom methods synchronous (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ipc comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/browser_view_renderer.cc ('k') | android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwContents.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java

index 06ead1d1c420d238965cd9c1d7b04ee25386908a..657f1f81078f37d1e287cf283edd36d3969ee06c 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java

@@ -2105,6 +2105,7 @@ public class AwContents implements SmartClipProvider,

throw new IllegalStateException("zoom delta value outside [0.01, 100] range.");

}

mContentViewCore.pinchByDelta(delta);

+ nativeSynchronizeRendererScroll(mNativeAwContents);

}

/**

@@ -3238,6 +3239,7 @@ public class AwContents implements SmartClipProvider,

long nativeAwContents, String path, ValueCallback<String> callback);

private native void nativeAddVisitedLinks(long nativeAwContents, String[] visitedLinks);

+ private native void nativeSynchronizeRendererScroll(long nativeAwContents);

private native void nativeOnComputeScroll(

long nativeAwContents, long currentAnimationTimeMillis);

private native boolean nativeOnDraw(long nativeAwContents, Canvas canvas,