Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1846633004: Revert of clang/win: Stop passing -Qunused-arguments. (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of clang/win: Stop passing -Qunused-arguments. (patchset #6 id:100001 of https://codereview.chromium.org/1828543003/ ) Reason for revert: Speculative; official builds mysteriously exploded (crbug.com/599186) and this is on the blame list... Original issue's description: > clang/win: Stop passing -Qunused-arguments. > > All flags except /GS and /GL are accepted by clang-cl by now. To be able > to turn on -Qunused-arguments, don't pass /GS and /GL in clang builds > for now. > > BUG=504658, 598772, 598767 > NOTRY=true > > Committed: https://crrev.com/de51a84b69b5b1dd458c65f6aaf2335f81b57785 > Cr-Commit-Position: refs/heads/master@{#383954} > > R=hans@chromium.org > > Committed: https://crrev.com/cb19a4e78e9c472914680235c75f2b9afe554b20 > Cr-Commit-Position: refs/heads/master@{#384004} TBR=hans@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=504658, 598772, 598767 Committed: https://crrev.com/12edf36d8d15b8f517b750b6dc1eb12e4d21f681 Cr-Commit-Position: refs/heads/master@{#384033}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -26 lines) Patch
M build/common.gypi View 4 chunks +4 lines, -19 lines 0 comments Download
M build/config/compiler/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M build/config/win/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Nico
Created Revert of clang/win: Stop passing -Qunused-arguments.
4 years, 8 months ago (2016-03-30 18:37:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846633004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846633004/1
4 years, 8 months ago (2016-03-30 18:38:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 18:38:39 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/12edf36d8d15b8f517b750b6dc1eb12e4d21f681 Cr-Commit-Position: refs/heads/master@{#384033}
4 years, 8 months ago (2016-03-30 18:41:56 UTC) #5
Nico
4 years, 8 months ago (2016-03-30 19:42:39 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1844793003/ by thakis@chromium.org.

The reason for reverting is: Wasn't the culprit for that problem..

Powered by Google App Engine
This is Rietveld 408576698