Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1846633002: Move SVGTextPositioningElement::elementFromLayoutObject (Closed)

Created:
4 years, 8 months ago by fs
Modified:
4 years, 8 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move SVGTextPositioningElement::elementFromLayoutObject ...to SVGTextLayoutAttributesBuilder.cpp, since that is where it's used. Turn the entry if into an ASSERT (because it's trivial to see that the condition always holds in this context.) BUG=594058 Committed: https://crrev.com/b38c00ea369443e37bcc94ef59ed2b5874d555c7 Cr-Commit-Position: refs/heads/master@{#384136}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp View 3 chunks +13 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTextPositioningElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTextPositioningElement.cpp View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
4 years, 8 months ago (2016-03-30 18:20:54 UTC) #2
pdr.
LGTM
4 years, 8 months ago (2016-03-30 23:04:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846633002/1
4 years, 8 months ago (2016-03-30 23:05:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 23:11:41 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 23:13:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b38c00ea369443e37bcc94ef59ed2b5874d555c7
Cr-Commit-Position: refs/heads/master@{#384136}

Powered by Google App Engine
This is Rietveld 408576698