Omnibox: Make URLs of Bookmarks Searchable

chrome/browser/bookmarks/DEPS

Index: chrome/browser/bookmarks/DEPS
diff --git a/chrome/browser/bookmarks/DEPS b/chrome/browser/bookmarks/DEPS
index a702b0e666e0fd9fa4a0cd8f060ca2b619de3166..e7b25b7bad923cb8b60f8cb579a749fcfe480838 100644
--- a/chrome/browser/bookmarks/DEPS
+++ b/chrome/browser/bookmarks/DEPS
@@ -17,6 +17,7 @@ include_rules = [
   "!chrome/browser/history/history_service_factory.h",
   "!chrome/browser/history/query_parser.h",
   "!chrome/browser/history/url_database.h",
+  "!chrome/browser/omnibox/omnibox_field_trial.h",

[sky, 2014/04/18 16:40:02]

There is work in progress to move all this code to components. We don't want
another dependency like this. You'll need to pass
OmniboxFieldTrial::BookmarksIndexURLsValue() through the constructor.
Alternative is wait for https://codereview.chromium.org/242693003/ to land then
wire through BookmarkClient interface.

[sky, 2014/04/18 16:52:20]

Actually, there may be threading issues if you try to express this through the
client interface. Safer to inject.

[Mark P, 2014/04/18 17:27:49]

You want me to bother even though this field trial will only exist for a
milestone or two?  (As soon as evals finish, we'll either turn it on by default
or remove the code.)

[Mark P, 2014/04/18 21:28:08]

I think the field trial will be useful, if only to say how big an improvement
this is.  I try to run field trials on everything so that if I see a change in
omnibox metrics from one release to the next, I can understand if it's the
expected result of everything we launched or if something else may have changed
(in a good or bad way) under the hood.

Do you want to review anything else in this changelist?

   "!chrome/browser/profiles/incognito_helpers.h",
   "!chrome/browser/profiles/profile.h",
   "!chrome/browser/profiles/startup_task_runner_service.h",