Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4044)

Unified Diff: chrome/browser/autocomplete/shortcuts_provider.cc

Issue 184663002: Omnibox: Make URLs of Bookmarks Searchable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tested; works Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/shortcuts_provider.cc
diff --git a/chrome/browser/autocomplete/shortcuts_provider.cc b/chrome/browser/autocomplete/shortcuts_provider.cc
index 6969b9b6fe9754db0ad9d284dfed5bab4c7a12b7..5d543bc7846fd675c26c646485e12941621309d1 100644
--- a/chrome/browser/autocomplete/shortcuts_provider.cc
+++ b/chrome/browser/autocomplete/shortcuts_provider.cc
@@ -216,11 +216,11 @@ AutocompleteMatch ShortcutsProvider::ShortcutToACMatch(
// If the match is a search query this is easy: simply check whether the
// user text is a prefix of the query. If the match is a navigation, we
// assume the fill_into_edit looks something like a URL, so we use
- // URLPrefix::ComputeMatchStartAndInlineAutocompleteOffset() to try and strip
- // off any prefixes that the user might not think would change the meaning,
- // but would otherwise prevent inline autocompletion. This allows, for
- // example, the input of "foo.c" to autocomplete to "foo.com" for a
- // fill_into_edit of "http://foo.com".
+ // URLPrefix::GetInlineAutocompleteOffset() to try and strip off any prefixes
+ // that the user might not think would change the meaning, but would
+ // otherwise prevent inline autocompletion. This allows, for example, the
+ // input of "foo.c" to autocomplete to "foo.com" for a fill_into_edit of
+ // "http://foo.com".
if (AutocompleteMatch::IsSearchType(match.type)) {
if (StartsWith(match.fill_into_edit, input.text(), false)) {
match.inline_autocompletion =
@@ -230,10 +230,9 @@ AutocompleteMatch ShortcutsProvider::ShortcutToACMatch(
match.inline_autocompletion.empty();
}
} else {
- size_t match_start, inline_autocomplete_offset;
- URLPrefix::ComputeMatchStartAndInlineAutocompleteOffset(
- input, fixed_up_input, true, match.fill_into_edit,
- &match_start, &inline_autocomplete_offset);
+ const size_t inline_autocomplete_offset =
+ URLPrefix::GetInlineAutocompleteOffset(
+ input, fixed_up_input, true, match.fill_into_edit);
if (inline_autocomplete_offset != base::string16::npos) {
match.inline_autocompletion =
match.fill_into_edit.substr(inline_autocomplete_offset);

Powered by Google App Engine
This is Rietveld 408576698