Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Side by Side Diff: chrome/browser/history/expire_history_backend_unittest.cc

Issue 184663002: Omnibox: Make URLs of Bookmarks Searchable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix ALL_MATCHES (in response to recent changes) Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <algorithm> 5 #include <algorithm>
6 #include <string> 6 #include <string>
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 // The test must be in the history namespace for the gtest forward declarations 49 // The test must be in the history namespace for the gtest forward declarations
50 // to work. It also eliminates a bunch of ugly "history::". 50 // to work. It also eliminates a bunch of ugly "history::".
51 namespace history { 51 namespace history {
52 52
53 // ExpireHistoryTest ----------------------------------------------------------- 53 // ExpireHistoryTest -----------------------------------------------------------
54 54
55 class ExpireHistoryTest : public testing::Test, 55 class ExpireHistoryTest : public testing::Test,
56 public BroadcastNotificationDelegate { 56 public BroadcastNotificationDelegate {
57 public: 57 public:
58 ExpireHistoryTest() 58 ExpireHistoryTest()
59 : bookmark_model_(NULL), 59 : bookmark_model_(NULL, false),
60 ui_thread_(BrowserThread::UI, &message_loop_), 60 ui_thread_(BrowserThread::UI, &message_loop_),
61 db_thread_(BrowserThread::DB, &message_loop_), 61 db_thread_(BrowserThread::DB, &message_loop_),
62 expirer_(this, &bookmark_model_), 62 expirer_(this, &bookmark_model_),
63 now_(Time::Now()) { 63 now_(Time::Now()) {
64 } 64 }
65 65
66 protected: 66 protected:
67 // Called by individual tests when they want data populated. 67 // Called by individual tests when they want data populated.
68 void AddExampleData(URLID url_ids[3], Time visit_times[4]); 68 void AddExampleData(URLID url_ids[3], Time visit_times[4]);
69 // Add visits with source information. 69 // Add visits with source information.
(...skipping 880 matching lines...) Expand 10 before | Expand all | Expand 10 after
950 main_db_->GetVisitsForURL(url_id, &archived_visits); 950 main_db_->GetVisitsForURL(url_id, &archived_visits);
951 EXPECT_EQ(0U, archived_visits.size()); 951 EXPECT_EQ(0U, archived_visits.size());
952 } 952 }
953 953
954 // TODO(brettw) add some visits with no URL to make sure everything is updated 954 // TODO(brettw) add some visits with no URL to make sure everything is updated
955 // properly. Have the visits also refer to nonexistent FTS rows. 955 // properly. Have the visits also refer to nonexistent FTS rows.
956 // 956 //
957 // Maybe also refer to invalid favicons. 957 // Maybe also refer to invalid favicons.
958 958
959 } // namespace history 959 } // namespace history
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698