Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5541)

Unified Diff: chrome/browser/ui/webui/options/password_manager_handler.cc

Issue 1846623002: Remove password-manager-reauthentication flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Just rebased Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/options/password_manager_handler.h ('k') | chrome/common/chrome_switches.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/password_manager_handler.cc
diff --git a/chrome/browser/ui/webui/options/password_manager_handler.cc b/chrome/browser/ui/webui/options/password_manager_handler.cc
index 88cd876535e596a531041459055ea683fe63443d..b6842fc9b8e0a343e82240b209bf46eb12d329e4 100644
--- a/chrome/browser/ui/webui/options/password_manager_handler.cc
+++ b/chrome/browser/ui/webui/options/password_manager_handler.cc
@@ -228,8 +228,7 @@ void PasswordManagerHandler::HandleUpdatePasswordLists(
}
void PasswordManagerHandler::SetPasswordList(
- const std::vector<scoped_ptr<autofill::PasswordForm>>& password_list,
- bool show_passwords) {
+ const std::vector<scoped_ptr<autofill::PasswordForm>>& password_list) {
base::ListValue entries;
languages_ = GetProfile()->GetPrefs()->GetString(prefs::kAcceptLanguages);
base::string16 placeholder(base::ASCIIToUTF16(" "));
@@ -238,14 +237,10 @@ void PasswordManagerHandler::SetPasswordList(
CopyOriginInfoOfPasswordForm(*saved_password, languages_, entry.get());
entry->SetString(kUsernameField, saved_password->username_value);
- if (show_passwords) {
- entry->SetString(kPasswordField, saved_password->password_value);
- } else {
- // Use a placeholder value with the same length as the password.
- entry->SetString(
- kPasswordField,
- base::string16(saved_password->password_value.length(), ' '));
- }
+ // Use a placeholder value with the same length as the password.
+ entry->SetString(
+ kPasswordField,
+ base::string16(saved_password->password_value.length(), ' '));
if (!saved_password->federation_origin.unique()) {
entry->SetString(
kFederationField,
« no previous file with comments | « chrome/browser/ui/webui/options/password_manager_handler.h ('k') | chrome/common/chrome_switches.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698