Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1846613002: [wasm] Fix and enable more tests. (Closed)

Created:
4 years, 8 months ago by titzer
Modified:
4 years, 8 months ago
Reviewers:
bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fix and enable more tests. R=ahaas@chromium.org, bradnelson@chromium.org BUG= Committed: https://crrev.com/08e0ea38cd5539e6427e3ffcf79c6fa87fc80497 Cr-Commit-Position: refs/heads/master@{#35156}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -62 lines) Patch
M test/cctest/wasm/test-run-wasm.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 1 4 chunks +41 lines, -33 lines 1 comment Download
M test/cctest/wasm/test-run-wasm-module.cc View 4 chunks +0 lines, -19 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 2 chunks +0 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 1 4 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
titzer
4 years, 8 months ago (2016-03-30 14:28:15 UTC) #1
titzer
On 2016/03/30 14:28:15, titzer wrote: PTAL. More tests enabled is more goodness.
4 years, 8 months ago (2016-03-31 09:05:31 UTC) #2
ahaas
lgtm https://codereview.chromium.org/1846613002/diff/20001/test/cctest/wasm/test-run-wasm-64.cc File test/cctest/wasm/test-run-wasm-64.cc (right): https://codereview.chromium.org/1846613002/diff/20001/test/cctest/wasm/test-run-wasm-64.cc#newcode894 test/cctest/wasm/test-run-wasm-64.cc:894: TEST_I64_BINOP(I64Shl, -7240704056088331264, 0xef4dc1ed030e8ffe, 9); Some instructions (e.g. shifts) ...
4 years, 8 months ago (2016-03-31 09:14:54 UTC) #3
titzer
On 2016/03/31 09:14:54, ahaas wrote: > lgtm > > https://codereview.chromium.org/1846613002/diff/20001/test/cctest/wasm/test-run-wasm-64.cc > File test/cctest/wasm/test-run-wasm-64.cc (right): > ...
4 years, 8 months ago (2016-03-31 09:17:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846613002/20001
4 years, 8 months ago (2016-03-31 09:18:05 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-31 09:20:06 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 09:20:26 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/08e0ea38cd5539e6427e3ffcf79c6fa87fc80497
Cr-Commit-Position: refs/heads/master@{#35156}

Powered by Google App Engine
This is Rietveld 408576698