Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1846603002: Enable gpusrgb config on bots. (Closed)

Created:
4 years, 8 months ago by Brian Osman
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Enable gpusrgb config on bots. Don't run the config if we can't get a context with srgb support. Includes a unit test for that logic. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1846603002 Committed: https://skia.googlesource.com/skia/+/61d3b08138d1820a2c9bb14764e83f6d3761207d

Patch Set 1 #

Patch Set 2 : w/json #

Patch Set 3 : Line length formatting #

Patch Set 4 : re-generate json #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4055 lines, -3950 lines) Patch
M dm/DM.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/GrContextFactory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrContextFactory.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/GrContextFactoryTest.cpp View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
M tools/dm_flags.json View 1 2 3 1 chunk +4019 lines, -3949 lines 1 comment Download
M tools/dm_flags.py View 1 2 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Brian Osman
Turning on one new config on all bots. Will be skipped on all machines that ...
4 years, 8 months ago (2016-03-30 14:34:35 UTC) #3
Brian Osman
On 2016/03/30 14:34:35, Brian Osman wrote: > Turning on one new config on all bots. ...
4 years, 8 months ago (2016-03-30 14:35:47 UTC) #4
Brian Osman
https://codereview.chromium.org/1846603002/diff/60001/tools/dm_flags.json File tools/dm_flags.json (right): https://codereview.chromium.org/1846603002/diff/60001/tools/dm_flags.json#newcode1514 tools/dm_flags.json:1514: "nvprdit4", Looks like cdalton submitted a change to the ...
4 years, 8 months ago (2016-03-30 14:40:40 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846603002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846603002/60001
4 years, 8 months ago (2016-03-30 14:41:03 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-30 14:57:56 UTC) #9
bsalomon
lgtm
4 years, 8 months ago (2016-03-30 18:16:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846603002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846603002/60001
4 years, 8 months ago (2016-03-30 18:18:40 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 18:19:40 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/61d3b08138d1820a2c9bb14764e83f6d3761207d

Powered by Google App Engine
This is Rietveld 408576698