Issue 18465003: Fix default type feedback returned from the oracle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18465003: Fix default type feedback returned from the oracle (Closed)

Created:
7 years, 5 months ago by Jakob Kummerow

Modified:
7 years, 5 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix default type feedback returned from the oracle R=rossberg@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15459

Patch Set 2 : added comments #

Patch Set 3 : added comments #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -13 lines)			Patch
	M	src/hydrogen.cc	View		2 chunks	+13 lines, -7 lines	0 comments	Download
	M	src/type-info.cc	View	1	3 chunks	+14 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rossberg

lgtm https://codereview.chromium.org/18465003/diff/1/src/type-info.cc File src/type-info.cc (right): https://codereview.chromium.org/18465003/diff/1/src/type-info.cc#newcode361 src/type-info.cc:361: *left_type = *right_type = *combined_type = handle(Type::None(), isolate_); ...

7 years, 5 months ago (2013-07-02 15:33:49 UTC) #2

Jakob Kummerow

Thanks, landing. https://codereview.chromium.org/18465003/diff/1/src/type-info.cc File src/type-info.cc (right): https://codereview.chromium.org/18465003/diff/1/src/type-info.cc#newcode361 src/type-info.cc:361: *left_type = *right_type = *combined_type = handle(Type::None(), ...

7 years, 5 months ago (2013-07-02 16:29:54 UTC) #3