Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1846473002: WTF: Implement move of Deques. (Closed)

Created:
4 years, 8 months ago by Yuta Kitamura
Modified:
4 years, 8 months ago
Reviewers:
*haraken, *tzik
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WTF: Implement move of Deques. As always, move constructor and move assignment operator are implemented in terms of swap(). Some existing tests are adjusted so CountCopy can count copies on assignments, too. BUG=567139, 582349 Committed: https://crrev.com/c5f5c10ed08fcc318284398ed60e3a58ddbeada3 Cr-Commit-Position: refs/heads/master@{#383932}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -10 lines) Patch
M third_party/WebKit/Source/wtf/Deque.h View 4 chunks +26 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/wtf/DequeTest.cpp View 1 chunk +40 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/HashMapTest.cpp View 1 chunk +9 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/HashSetTest.cpp View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846473002/1
4 years, 8 months ago (2016-03-30 00:55:03 UTC) #2
Yuta Kitamura
tzik, haraken: PTAL?
4 years, 8 months ago (2016-03-30 00:55:28 UTC) #6
haraken
LGTM
4 years, 8 months ago (2016-03-30 00:58:29 UTC) #7
tzik
lgtm
4 years, 8 months ago (2016-03-30 03:46:50 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/195936)
4 years, 8 months ago (2016-03-30 07:02:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846473002/1
4 years, 8 months ago (2016-03-30 07:10:52 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 08:39:30 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 08:40:37 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5f5c10ed08fcc318284398ed60e3a58ddbeada3
Cr-Commit-Position: refs/heads/master@{#383932}

Powered by Google App Engine
This is Rietveld 408576698