Issue 1846443002: - Remove --coverage_dir flag and old-style coverage service requests.

Issue 1846443002: - Remove --coverage_dir flag and old-style coverage service requests. (Closed)

Created:
4 years, 8 months ago by Ivan Posva

Modified:
4 years, 8 months ago

Reviewers:
turnidge, Chris Bracken, kevmoo

CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

- Remove --coverage_dir flag and old-style coverage service requests. BUG= Committed: https://github.com/dart-lang/sdk/commit/c434931517ae2a05f96b26c0fe6ff581d322ed02

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1744 lines)			Patch
D	runtime/observatory/tests/service/call_site_data_test.dart	View	1	1 chunk	+0 lines, -189 lines	0 comments	Download
D	runtime/observatory/tests/service/coverage_test.dart	View	1	1 chunk	+0 lines, -138 lines	0 comments	Download
D	runtime/vm/coverage.h	View		1 chunk	+0 lines, -57 lines	0 comments	Download
D	runtime/vm/coverage.cc	View		1 chunk	+0 lines, -313 lines	0 comments	Download
D	runtime/vm/coverage_test.cc	View		1 chunk	+0 lines, -144 lines	0 comments	Download
M	runtime/vm/flag_list.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/isolate.cc	View		2 chunks	+0 lines, -7 lines	0 comments	Download
M	runtime/vm/object.cc	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/service.cc	View		4 chunks	+0 lines, -132 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View		1 chunk	+0 lines, -3 lines	0 comments	Download
D	tests/standalone/full_coverage_test.dart	View	1	1 chunk	+0 lines, -247 lines	0 comments	Download
D	tools/full-coverage.dart	View	1	1 chunk	+0 lines, -507 lines	0 comments	Download

Total messages: 7 (3 generated)

Ivan Posva

This is ready to be submitted after the next cut of dev release. -Ivan

4 years, 8 months ago (2016-03-30 16:52:01 UTC) #2

Ivan Posva

Committed patchset #2 (id:20001) manually as c434931517ae2a05f96b26c0fe6ff581d322ed02 (presubmit successful).

4 years, 8 months ago (2016-04-07 23:24:55 UTC) #5

kevmoo

4 years, 8 months ago (2016-04-07 23:50:45 UTC) #7

Message was sent while issue was closed.

We need to update the changelog that this is happening, too.