Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 1846433002: DevTools: [SSP] accept editing on mouse click (Closed)

Created:
4 years, 8 months ago by lushnikov
Modified:
4 years, 8 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [SSP] accept editing on mouse click This behavior was regressed back in http://crrev.com/1649533003. BUG=598919 R=pfeldman, dgozman Committed: https://crrev.com/5d556d4423750cbbcc7d8ac7cd28c1e3b5f6c9fd Cr-Commit-Position: refs/heads/master@{#383889}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
lushnikov
ptal
4 years, 8 months ago (2016-03-29 23:40:33 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846433002/1
4 years, 8 months ago (2016-03-29 23:41:26 UTC) #3
pfeldman
Lets get a "regression" bug for it - we need to merge it.
4 years, 8 months ago (2016-03-29 23:43:40 UTC) #5
pfeldman
(lgtm)
4 years, 8 months ago (2016-03-29 23:44:01 UTC) #6
lushnikov
a new patchset supports committing any edits from property name
4 years, 8 months ago (2016-03-30 00:18:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846433002/20001
4 years, 8 months ago (2016-03-30 00:19:09 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-30 01:21:53 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 01:23:30 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5d556d4423750cbbcc7d8ac7cd28c1e3b5f6c9fd
Cr-Commit-Position: refs/heads/master@{#383889}

Powered by Google App Engine
This is Rietveld 408576698