chrome/browser/resources/md_downloads/vulcanize.py - Issue 1846383002: MD Downloads: fix vulcanize issues by excluding higher up in the dependency tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_downloads/vulcanize.py

Issue 1846383002: MD Downloads: fix vulcanize issues by excluding higher up in the dependency tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/md_downloads/vulcanize.py

diff --git a/chrome/browser/resources/md_downloads/vulcanize.py b/chrome/browser/resources/md_downloads/vulcanize.py

index 3ef22dc316f58735a30feaf0ea2290cc48f8de57..6ef0f5938f9c7a1f3b8eba7e9f4a8089af2193bc 100755

--- a/chrome/browser/resources/md_downloads/vulcanize.py

+++ b/chrome/browser/resources/md_downloads/vulcanize.py

@@ -34,9 +34,13 @@ _VULCANIZE_ARGS = [

'--exclude', 'polymer-extracted.js',

'--exclude', 'polymer-micro-extracted.js',

'--exclude', 'polymer-mini-extracted.js',

- '--exclude', 'polymer_config.js',

'--exclude', 'web-animations-next-lite.min.js',

+ # Because we're excluding polymer-* files, they are run earlier as separate

+ # <script>s. polymer_config.js must run before any polymer-*.js, so it must be

+ # excluded from vulcanization as well to have any effect.

+ '--exclude', 'polymer_config.js',

# These files are dynamically created by C++.

'--exclude', 'load_time_data.js',

'--exclude', 'strings.js',

« no previous file with comments | « no previous file | chrome/test/data/webui/polymer_browser_test_base.js » ('j') | chrome/test/data/webui/polymer_browser_test_base.js » ('J')