MD Downloads: fix vulcanize issues by excluding higher up in the dependency tree

MD Downloads: fix vulcanize issues by excluding higher up in the dependency tree

This implicitly aligns tests and production code, and updates
tests to use the less error-prone way to import Polymer.

R=michaelpg@chromium.org
BUG=599373
NOPRESUBMIT=true  # crisper.js

Committed: https://crrev.com/aab97446e6551cf50a2078473e8a8c7b766cb8db
Cr-Commit-Position: refs/heads/master@{#385100}

[Dan Beam, 2016-04-02 01:49:11]

Description was changed from

==========
MD Downloads: work around vulcanize bug by moving <script> to <link rel=import>

R=michaelpg@chromium.org
BUG=none
==========

to

==========
MD Downloads: work around vulcanize bug by moving <script> to <link rel=import>

R=michaelpg@chromium.org
BUG=599373
==========

[michaelpg, 2016-04-02 01:58:52]

lgtm

[michaelpg, 2016-04-05 00:49:42]

https://codereview.chromium.org/1846383002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/polymer_browser_test_base.js (left):

https://codereview.chromium.org/1846383002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/polymer_browser_test_base.js:94: if (typeof Polymer !=
'function') {
maybe keep this as 
    if (!Polymer) {

https://codereview.chromium.org/1846383002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/polymer_browser_test_base.js (right):

https://codereview.chromium.org/1846383002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/polymer_browser_test_base.js:94:
PolymerTest.importHtml('chrome://resources/html/polymer.html'),
this assumes the page being tested doesn't load
    <script src="chrome://resources/js/polymer_config.js"></script>

which is untrue for pages that don't use chrome://resources/html/polymer.html,
like MediaRouter (this will cause MediaRouterElementsBrowserTest to fail)

[Dan Beam, 2016-04-05 01:38:58]

https://codereview.chromium.org/1846383002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/polymer_browser_test_base.js (right):

https://codereview.chromium.org/1846383002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/polymer_browser_test_base.js:94:
PolymerTest.importHtml('chrome://resources/html/polymer.html'),
On 2016/04/05 00:49:42, michaelpg wrote:
> this assumes the page being tested doesn't load
>     <script src="chrome://resources/js/polymer_config.js"></script>
> 
> which is untrue for pages that don't use chrome://resources/html/polymer.html,
> like MediaRouter (this will cause MediaRouterElementsBrowserTest to fail)

why doesn't media router stuff use polymer.html?

[Dan Beam, 2016-04-05 02:15:47]

Patchset #3 (id:40001) has been deleted

[Dan Beam, 2016-04-05 02:57:53]

Description was changed from

==========
MD Downloads: work around vulcanize bug by moving <script> to <link rel=import>

R=michaelpg@chromium.org
BUG=599373
==========

to

==========
MD Downloads: fix vulcanize issues by excluding higher up in the dependency tree

This implicitly aligns tests and production code, and updates
tests to use the less error-prone way to import Polymer.

R=michaelpg@chromium.org
BUG=599373
==========

[Dan Beam, 2016-04-05 03:56:19]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-04-05 03:56:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/1846383002/#ps80001
(title: "just polymer.html")

[commit-bot: I haz the power, 2016-04-05 03:56:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1846383002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1846383002/80001

[michaelpg, 2016-04-05 03:58:02]

trepidatiously slgtm

[commit-bot: I haz the power, 2016-04-05 04:05:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 04:05:06]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Dan Beam, 2016-04-05 04:06:05]

Description was changed from

==========
MD Downloads: fix vulcanize issues by excluding higher up in the dependency tree

This implicitly aligns tests and production code, and updates
tests to use the less error-prone way to import Polymer.

R=michaelpg@chromium.org
BUG=599373
==========

to

==========
MD Downloads: fix vulcanize issues by excluding higher up in the dependency tree

This implicitly aligns tests and production code, and updates
tests to use the less error-prone way to import Polymer.

R=michaelpg@chromium.org
BUG=599373

NOPRESUBMIT=true  # crisper.js
==========

[Dan Beam, 2016-04-05 04:06:10]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-04-05 04:06:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1846383002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1846383002/80001

[commit-bot: I haz the power, 2016-04-05 04:13:53]

Description was changed from

==========
MD Downloads: fix vulcanize issues by excluding higher up in the dependency tree

This implicitly aligns tests and production code, and updates
tests to use the less error-prone way to import Polymer.

R=michaelpg@chromium.org
BUG=599373

NOPRESUBMIT=true  # crisper.js
==========

to

==========
MD Downloads: fix vulcanize issues by excluding higher up in the dependency tree

This implicitly aligns tests and production code, and updates
tests to use the less error-prone way to import Polymer.

R=michaelpg@chromium.org
BUG=599373

NOPRESUBMIT=true  # crisper.js
==========

[commit-bot: I haz the power, 2016-04-05 04:13:54]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-04-05 04:15:24]

Description was changed from

==========
MD Downloads: fix vulcanize issues by excluding higher up in the dependency tree

This implicitly aligns tests and production code, and updates
tests to use the less error-prone way to import Polymer.

R=michaelpg@chromium.org
BUG=599373

NOPRESUBMIT=true  # crisper.js
==========

to

==========
MD Downloads: fix vulcanize issues by excluding higher up in the dependency tree

This implicitly aligns tests and production code, and updates
tests to use the less error-prone way to import Polymer.

R=michaelpg@chromium.org
BUG=599373

NOPRESUBMIT=true  # crisper.js

Committed: https://crrev.com/aab97446e6551cf50a2078473e8a8c7b766cb8db
Cr-Commit-Position: refs/heads/master@{#385100}
==========

[commit-bot: I haz the power, 2016-04-05 04:15:25]

Patchset 4 (id:??) landed as
https://crrev.com/aab97446e6551cf50a2078473e8a8c7b766cb8db
Cr-Commit-Position: refs/heads/master@{#385100}

[Dan Beam, 2016-04-05 16:13:42]

afaict, this has no tangible performance impact