storage/common/blob_storage/blob_storage_constants.h - Issue 1846363002: [BlobAsync] Adding better error reporting and some new tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: storage/common/blob_storage/blob_storage_constants.h

Issue 1846363002: [BlobAsync] Adding better error reporting and some new tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed switch statement Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: storage/common/blob_storage/blob_storage_constants.h

diff --git a/storage/common/blob_storage/blob_storage_constants.h b/storage/common/blob_storage/blob_storage_constants.h

index c56241dc04628212345c5b43d22c3e32fc83322b..5ed0c6fb2c80597747a80b4b92b4744b15df2dab 100644

--- a/storage/common/blob_storage/blob_storage_constants.h

+++ b/storage/common/blob_storage/blob_storage_constants.h

@@ -34,6 +34,7 @@ enum class IPCBlobItemRequestStrategy {

enum class IPCBlobCreationCancelCode {

UNKNOWN = 0,

OUT_OF_MEMORY = 1,

+ // We couldn't create or write to a file. File system error, like a full hdd.

jsbell 2016/04/04 20:41:19 nit: just say "disk"

dmurph 2016/04/04 22:17:42 Done.

FILE_WRITE_FAILED = 2,

// The renderer was destroyed while data was in transit.

SOURCE_DIED_IN_TRANSIT = 3,

« storage/browser/blob/blob_data_handle.cc ('K') | « storage/browser/blob/blob_storage_registry.h ('k') | no next file » | no next file with comments »