storage/browser/blob/blob_reader.h - Issue 1846363002: [BlobAsync] Adding better error reporting and some new tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: storage/browser/blob/blob_reader.h

Issue 1846363002: [BlobAsync] Adding better error reporting and some new tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed switch statement Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« storage/browser/blob/blob_data_handle.cc ('K') | « storage/browser/blob/blob_data_handle.cc ('k') | storage/browser/blob/blob_reader.cc » ('j') | storage/common/blob_storage/blob_storage_constants.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: storage/browser/blob/blob_reader.h

diff --git a/storage/browser/blob/blob_reader.h b/storage/browser/blob/blob_reader.h

index 4ddd738ed17c1720f7a8becfa2ae530900bcbf0e..fa10f04db19bf83fb40139f8038d6dae215d421d 100644

--- a/storage/browser/blob/blob_reader.h

+++ b/storage/browser/blob/blob_reader.h

@@ -16,6 +16,7 @@

#include "base/memory/weak_ptr.h"

#include "net/base/completion_callback.h"

#include "storage/browser/storage_browser_export.h"

+#include "storage/common/blob_storage/blob_storage_constants.h"

class GURL;

@@ -131,7 +132,8 @@ class STORAGE_EXPORT BlobReader {

void InvalidateCallbacksAndDone(int net_error, net::CompletionCallback done);

void AsyncCalculateSize(const net::CompletionCallback& done,

- bool async_succeeded);

+ bool async_succeeded,

+ IPCBlobCreationCancelCode reason);

Status CalculateSizeImpl(const net::CompletionCallback& done);

bool AddItemLength(size_t index, uint64_t length);

bool ResolveFileItemLength(const BlobDataItem& item,