Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: storage/browser/blob/blob_async_builder_host.h

Issue 1846363002: [BlobAsync] Adding better error reporting and some new tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed switch statement Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: storage/browser/blob/blob_async_builder_host.h
diff --git a/storage/browser/blob/blob_async_builder_host.h b/storage/browser/blob/blob_async_builder_host.h
index 3b9b095574881b29dbef37bf5a568e4bede0a750..19846de6d93414e027023e1d8ddc1dea3ca08f1c 100644
--- a/storage/browser/blob/blob_async_builder_host.h
+++ b/storage/browser/blob/blob_async_builder_host.h
@@ -109,7 +109,8 @@ class STORAGE_EXPORT BlobAsyncBuilderHost {
// This clears this object of pending construction. It also handles marking
// blobs that haven't been fully constructed as broken in the context if there
- // are any references being held by anyone.
+ // are any references being held by anyone. We know that they're being used
+ // by someone else if they still exist in the context.
void CancelAll(BlobStorageContext* context);
size_t blob_building_count() const { return async_blob_map_.size(); }
@@ -177,7 +178,8 @@ class STORAGE_EXPORT BlobAsyncBuilderHost {
// complete the blob and erase our internal state.
void ReferencedBlobFinished(const std::string& uuid,
base::WeakPtr<BlobStorageContext> context,
- bool construction_success);
+ bool construction_success,
+ IPCBlobCreationCancelCode reason);
// This finishes creating the blob in the context, decrements blob references
// that we were holding during construction, and erases our state.

Powered by Google App Engine
This is Rietveld 408576698