Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: storage/browser/blob/blob_storage_context.h

Issue 1846363002: [BlobAsync] Adding better error reporting and some new tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « storage/browser/blob/blob_reader.cc ('k') | storage/browser/blob/blob_storage_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: storage/browser/blob/blob_storage_context.h
diff --git a/storage/browser/blob/blob_storage_context.h b/storage/browser/blob/blob_storage_context.h
index 86cdab8a0551920734772b3d9ddbb69e4e69897b..8553d0266d2d8b6338a176f4e9d9ce9d7675fa85 100644
--- a/storage/browser/blob/blob_storage_context.h
+++ b/storage/browser/blob/blob_storage_context.h
@@ -85,6 +85,7 @@ class STORAGE_EXPORT BlobStorageContext
private:
using BlobRegistryEntry = BlobStorageRegistry::Entry;
+ using BlobConstructedCallback = BlobStorageRegistry::BlobConstructedCallback;
friend class content::BlobDispatcherHost;
friend class BlobAsyncBuilderHost;
friend class BlobAsyncBuilderHostTest;
@@ -124,9 +125,11 @@ class STORAGE_EXPORT BlobStorageContext
std::unique_ptr<BlobDataSnapshot> CreateSnapshot(const std::string& uuid);
bool IsBroken(const std::string& uuid) const;
bool IsBeingBuilt(const std::string& uuid) const;
- // Runs |done| when construction completes, with true if it was successful.
+ // Runs |done| when construction completes, with true if it was successful,
+ // and false if there was an error, which is reported in the second argument
+ // of the callback.
void RunOnConstructionComplete(const std::string& uuid,
- const base::Callback<void(bool)>& done);
+ const BlobConstructedCallback& done);
// Appends the given blob item to the blob builder. The new blob
// retains ownership of data_item if applicable, and returns false if there
« no previous file with comments | « storage/browser/blob/blob_reader.cc ('k') | storage/browser/blob/blob_storage_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698