[BlobAsync] Adding better error reporting and some new tests.

storage/browser/blob/blob_storage_context.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "storage/browser/blob/blob_storage_context.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <algorithm>
 #include <limits>
@@ skipping 142 matching lines @@
   size_t total_memory = 0, nonshared_memory = 0;
   entry->data->GetMemoryUsage(&total_memory, &nonshared_memory);
   UMA_HISTOGRAM_COUNTS("Storage.Blob.TotalSize", total_memory / 1024);
   UMA_HISTOGRAM_COUNTS("Storage.Blob.TotalUnsharedSize",
                        nonshared_memory / 1024);
   TRACE_COUNTER1("Blob", "MemoryStoreUsageBytes", memory_usage_);
 
   auto runner = base::ThreadTaskRunnerHandle::Get();
   for (const auto& callback : entry->build_completion_callbacks) {
     runner->PostTask(FROM_HERE,
-                     base::Bind(callback, entry->state == BlobState::COMPLETE));
+                     base::Bind(callback, entry->state == BlobState::COMPLETE,
+                                entry->broken_reason));
   }
   entry->build_completion_callbacks.clear();
 }
 
 void BlobStorageContext::CancelPendingBlob(const std::string& uuid,
                                            IPCBlobCreationCancelCode reason) {
   BlobRegistryEntry* entry = registry_.GetEntry(uuid);
   DCHECK(entry && entry->state == BlobState::PENDING);
   entry->state = BlobState::BROKEN;
   entry->broken_reason = reason;
@@ skipping 51 matching lines @@
 bool BlobStorageContext::IsBeingBuilt(const std::string& uuid) const {
   const BlobRegistryEntry* entry = registry_.GetEntry(uuid);
   if (!entry) {
     return false;
   }
   return entry->state == BlobState::PENDING;
 }
 
 void BlobStorageContext::RunOnConstructionComplete(
     const std::string& uuid,
-    const base::Callback<void(bool)>& done) {
+    const BlobConstructedCallback& done) {
   BlobRegistryEntry* entry = registry_.GetEntry(uuid);
   DCHECK(entry);
   switch (entry->state) {
     case BlobState::COMPLETE:
-      done.Run(true);
+      done.Run(true, IPCBlobCreationCancelCode::UNKNOWN);
       return;
     case BlobState::BROKEN:
-      done.Run(false);
+      done.Run(false, entry->broken_reason);
       return;
     case BlobState::PENDING:
       entry->build_completion_callbacks.push_back(done);
       return;
   }
   NOTREACHED();
 }
 
 bool BlobStorageContext::AppendAllocatedBlobItem(
     const std::string& target_blob_uuid,
@@ skipping 189 matching lines @@
       case DataElement::TYPE_UNKNOWN:
         CHECK(false) << "Illegal blob item type: " << item.type();
     }
     length -= new_length;
     offset = 0;
   }
   return true;
 }
 
 }  // namespace storage