[BlobAsync] Adding better error reporting and some new tests.

storage/browser/blob/blob_data_handle.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "storage/browser/blob/blob_data_handle.h"
 
 #include <stdint.h>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 54 matching lines @@
     const std::string& content_type,
     const std::string& content_disposition,
     BlobStorageContext* context)
     : uuid_(uuid),
       content_type_(content_type),
       content_disposition_(content_disposition),
       context_(context->AsWeakPtr()) {
   context_->IncrementBlobRefCount(uuid);
 }
 
-void BlobDataHandle::BlobDataHandleShared::RunOnConstructionComplete(
-    const base::Callback<void(bool)>& done) {
-  if (!context_.get()) {
-    done.Run(false);
-    return;
-  }
-  context_->RunOnConstructionComplete(uuid_, done);
-}
-
 scoped_ptr<BlobReader> BlobDataHandle::CreateReader(
     FileSystemContext* file_system_context,
     base::SequencedTaskRunner* file_task_runner) const {
   return scoped_ptr<BlobReader>(new BlobReader(
       this, scoped_ptr<BlobReader::FileStreamReaderProvider>(
                 new FileStreamReaderProviderImpl(file_system_context)),
       file_task_runner));
 }
 
-scoped_ptr<BlobDataSnapshot>
-BlobDataHandle::BlobDataHandleShared::CreateSnapshot() const {
-  if (!context_.get())
-    return nullptr;
-  return context_->CreateSnapshot(uuid_);
-}
-
 BlobDataHandle::BlobDataHandleShared::~BlobDataHandleShared() {
   if (context_.get())
     context_->DecrementBlobRefCount(uuid_);
 }
 
 BlobDataHandle::BlobDataHandle(const std::string& uuid,
                                const std::string& content_type,
                                const std::string& content_disposition,
                                BlobStorageContext* context,
                                base::SequencedTaskRunner* io_task_runner)
@@ skipping 28 matching lines @@
 }
 
 bool BlobDataHandle::IsBroken() const {
   DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
   if (!shared_->context_)
     return true;
   return shared_->context_->IsBroken(shared_->uuid_);
 }
 
 void BlobDataHandle::RunOnConstructionComplete(
-    const base::Callback<void(bool)>& done) {
+    const BlobConstructedCallback& done) {
   DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
-  shared_->RunOnConstructionComplete(done);
+  if (!shared_->context_.get()) {
+    done.Run(false, IPCBlobCreationCancelCode::UNKNOWN);

[jsbell, 2016/04/04 20:41:19]

Add a code for this case?

[dmurph, 2016/04/04 22:17:42]

This is a crazy edge case, where the context is even around (so our system is
shutting down). I'm not sure if this warrants an enum value. Michael, WDYT?

+    return;
+  }
+  shared_->context_->RunOnConstructionComplete(shared_->uuid_, done);
 }
 
 scoped_ptr<BlobDataSnapshot> BlobDataHandle::CreateSnapshot() const {
   DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
-  return shared_->CreateSnapshot();
+  if (!shared_->context_.get())
+    return nullptr;
+  return shared_->context_->CreateSnapshot(shared_->uuid_);
 }
 
 const std::string& BlobDataHandle::uuid() const {
   return shared_->uuid_;
 }
 
 const std::string& BlobDataHandle::content_type() const {
   return shared_->content_type_;
 }
 
 const std::string& BlobDataHandle::content_disposition() const {
   return shared_->content_disposition_;
 }
 
 }  // namespace storage