Remove CFX_ string type static initializers.

Remove CFX_ string type static initializers.

In XFA, we were constructing some CFX_ string types before
we reached main(). Setting breakpoints on these as well as
main() shows we hit main first after applying the patch.

Doing so also turned up an unused variable, presumably because
the static initializer made it appear used.

Committed: https://pdfium.googlesource.com/pdfium/+/4af5fd19d4101079d5a47412e07a5daaf3dade6e

[Tom Sepez, 2016-04-01 22:13:08]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-04-01 22:13:09]

Lei, quick review.  Thanks.

[Lei Zhang, 2016-04-01 22:20:54]

lgtm

[Tom Sepez, 2016-04-01 22:25:00]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-04-01 22:25:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1846353002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1846353002/1

[commit-bot: I haz the power, 2016-04-01 22:31:45]

Description was changed from

==========
Remove CFX_ string type static initializers.

In XFA, we were constructing some CFX_ string types before
we reached main(). Setting breakpoints on these as well as
main() shows we hit main first after applying the patch.

Doing so also turned up an unused variable, presumably because
the static initializer made it appear used.
==========

to

==========
Remove CFX_ string type static initializers.

In XFA, we were constructing some CFX_ string types before
we reached main(). Setting breakpoints on these as well as
main() shows we hit main first after applying the patch.

Doing so also turned up an unused variable, presumably because
the static initializer made it appear used.

Committed:
https://pdfium.googlesource.com/pdfium/+/4af5fd19d4101079d5a47412e07a5daaf3da...
==========

[commit-bot: I haz the power, 2016-04-01 22:31:46]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/4af5fd19d4101079d5a47412e07a5daaf3da...