Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1846343002: Enable BoringSSL for Android in GN build (Closed)

Created:
4 years, 8 months ago by zra
Modified:
4 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -1 line) Patch
M runtime/bin/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
A third_party/boringssl/BUILD.gn View 1 chunk +95 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
zra
This is the change needed to turn on dart:io secure sockets for Flutter on Android. ...
4 years, 8 months ago (2016-04-01 22:06:26 UTC) #2
Ivan Posva
LGTM -ip
4 years, 8 months ago (2016-04-08 13:19:21 UTC) #3
zra
4 years, 8 months ago (2016-04-26 16:13:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b1ece64035f6e7275712f97b233b72c2d096c6f7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698