Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 184633007: Don't emit a default namespace declaration if it's already the default (Closed)

Created:
6 years, 9 months ago by fs
Modified:
6 years, 9 months ago
Reviewers:
adamk
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Don't emit a default namespace declaration if it's already the default If an element declares a new default namespace (has an xmlns="..." attribute) make sure said namespace is used to update the namespace-table. This avoids having to emit a default namespace declaration for descendants of said element. BUG=340794 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168672

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -35 lines) Patch
A LayoutTests/fast/dom/XMLSerializer-element-ns-no-reemit.html View 1 chunk +28 lines, -0 lines 0 comments Download
M LayoutTests/inspector/elements/set-outer-html-for-xhtml-expected.txt View 10 chunks +30 lines, -30 lines 0 comments Download
M Source/core/editing/MarkupAccumulator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/MarkupAccumulator.cpp View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
fs
6 years, 9 months ago (2014-03-06 13:33:45 UTC) #1
adamk
lgtm
6 years, 9 months ago (2014-03-06 19:23:08 UTC) #2
fs
The CQ bit was checked by fs@opera.com
6 years, 9 months ago (2014-03-06 19:29:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/184633007/1
6 years, 9 months ago (2014-03-06 19:29:37 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 20:03:21 UTC) #5
Message was sent while issue was closed.
Change committed as 168672

Powered by Google App Engine
This is Rietveld 408576698