Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 184633005: [CSS Font Loading] Remove FontFace#ready, fold its functionality into FontFace#load (Closed)

Created:
6 years, 9 months ago by Kunihiko Sakamoto
Modified:
6 years, 9 months ago
Reviewers:
dglazkov, eae
CC:
blink-reviews, arv+blink, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, Inactive, darktears, rune+blink, watchdog-blink-watchlist_google.com, rwlbuis
Visibility:
Public.

Description

[CSS Font Loading] Remove FontFace#ready, fold its functionality into FontFace#load As per a discussion on www-style [1], FontFace#ready is removed from the spec [2], and FontFace#load() is changed to return a Promise which fulfills when the font is ready. [1] http://lists.w3.org/Archives/Public/www-style/2014Mar/0069.html [2] http://dev.w3.org/csswg/css-font-loading/ TEST=fast/css/fontface-methods.html BUG=53213 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169507

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -35 lines) Patch
M LayoutTests/fast/css/fontface-arraybuffer.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/fontface-methods.html View 4 chunks +5 lines, -9 lines 0 comments Download
M LayoutTests/fast/css/fontface-methods-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/fontfaceset-add-remove-while-loading.html View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/css/FontFace.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/FontFace.cpp View 1 2 chunks +13 lines, -17 lines 0 comments Download
M Source/core/css/FontFace.idl View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Kunihiko Sakamoto
6 years, 9 months ago (2014-03-06 10:15:14 UTC) #1
dglazkov
lgtm.
6 years, 9 months ago (2014-03-06 18:41:39 UTC) #2
Kunihiko Sakamoto
The CQ bit was checked by ksakamoto@chromium.org
6 years, 9 months ago (2014-03-07 00:55:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/184633005/1
6 years, 9 months ago (2014-03-07 00:56:03 UTC) #4
Kunihiko Sakamoto
The CQ bit was unchecked by ksakamoto@chromium.org
6 years, 9 months ago (2014-03-07 01:20:59 UTC) #5
Kunihiko Sakamoto
I would like to wait for the discussion thread in www-style to settle down.
6 years, 9 months ago (2014-03-07 10:27:58 UTC) #6
Kunihiko Sakamoto
The CQ bit was checked by ksakamoto@chromium.org
6 years, 9 months ago (2014-03-18 10:58:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/184633005/20001
6 years, 9 months ago (2014-03-18 10:58:27 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 11:05:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-18 11:05:10 UTC) #10
Kunihiko Sakamoto
The CQ bit was checked by ksakamoto@chromium.org
6 years, 9 months ago (2014-03-19 01:06:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/184633005/20001
6 years, 9 months ago (2014-03-19 01:06:35 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 02:44:57 UTC) #13
Message was sent while issue was closed.
Change committed as 169507

Powered by Google App Engine
This is Rietveld 408576698