Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/Source/core/html/HTMLFrameElementBase.cpp

Issue 184633004: Revert 168553 "id of iframe incorrectly sets window name" (Closed) Base URL: svn://svn.chromium.org/blink/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/LayoutTests/plugins/plugin-remove-subframe.html ('k') | trunk/Source/web/tests/data/iframe_redirect.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/Source/core/html/HTMLFrameElementBase.cpp
===================================================================
--- trunk/Source/core/html/HTMLFrameElementBase.cpp (revision 168578)
+++ trunk/Source/core/html/HTMLFrameElementBase.cpp (working copy)
@@ -137,6 +137,8 @@
void HTMLFrameElementBase::setNameAndOpenURL()
{
m_frameName = getNameAttribute();
+ if (m_frameName.isNull())
+ m_frameName = getIdAttribute();
openURL();
}
« no previous file with comments | « trunk/LayoutTests/plugins/plugin-remove-subframe.html ('k') | trunk/Source/web/tests/data/iframe_redirect.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698