Add assertions to FrameSummary and Code::SourcePosition.

src/frames.cc

Index: src/frames.cc
diff --git a/src/frames.cc b/src/frames.cc
index cfacbac45922f547258b75a11f179828aa4b96f3..bcc345a8b1fda8ec59e3b3405c84dba08bb426de 100644
--- a/src/frames.cc
+++ b/src/frames.cc
@@ -954,6 +954,11 @@ void JavaScriptFrame::RestoreOperandStack(FixedArray* store) {
   }
 }
 
+bool CannotDeoptFromAsmCode(Code* code, JSFunction* function) {

[Benedikt Meurer, 2016/04/01 07:50:21]

Nit: Put into anonymous namespace.

+  return code->is_turbofanned() && function->shared()->asm_function() &&
+         !FLAG_turbo_asm_deoptimization;
+}
+
 FrameSummary::FrameSummary(Object* receiver, JSFunction* function,
                            AbstractCode* abstract_code, int code_offset,
                            bool is_constructor)
@@ -961,7 +966,11 @@ FrameSummary::FrameSummary(Object* receiver, JSFunction* function,
       function_(function),
       abstract_code_(abstract_code),
       code_offset_(code_offset),
-      is_constructor_(is_constructor) {}
+      is_constructor_(is_constructor) {
+  DCHECK(abstract_code->IsBytecodeArray() ||
+         Code::cast(abstract_code)->kind() != Code::OPTIMIZED_FUNCTION ||
+         CannotDeoptFromAsmCode(Code::cast(abstract_code), function));
+}
 
 void FrameSummary::Print() {
   PrintF("receiver: ");
@@ -973,7 +982,10 @@ void FrameSummary::Print() {
   if (abstract_code_->IsCode()) {
     Code* code = abstract_code_->GetCode();
     if (code->kind() == Code::FUNCTION) PrintF(" UNOPT ");
-    if (code->kind() == Code::OPTIMIZED_FUNCTION) PrintF(" OPT ");
+    if (code->kind() == Code::OPTIMIZED_FUNCTION) {
+      DCHECK(CannotDeoptFromAsmCode(code, *function()));
+      PrintF(" ASM ");
+    }
   } else {
     PrintF(" BYTECODE ");
   }
@@ -989,8 +1001,7 @@ void OptimizedFrame::Summarize(List<FrameSummary>* frames) {
   // TODO(turbofan): Revisit once we support deoptimization across the board.
   Code* code = LookupCode();
   if (code->kind() == Code::BUILTIN ||
-      (code->is_turbofanned() && function()->shared()->asm_function() &&
-       !FLAG_turbo_asm_deoptimization)) {
+      CannotDeoptFromAsmCode(code, function())) {
     return JavaScriptFrame::Summarize(frames);
   }