Issue 184613003: Avoid double attribute lookup in HTMLElement::matchesReadWritePseudoClass()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 184613003: Avoid double attribute lookup in HTMLElement::matchesReadWritePseudoClass() (Closed)

Created:
6 years, 9 months ago by Inactive

Modified:
6 years, 9 months ago

Reviewers:
eseidel, adamk, rwlbuis

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Avoid double attribute lookup in HTMLElement::matchesReadWritePseudoClass() Avoid double attribute lookup in HTMLElement::matchesReadWritePseudoClass(). Instead of calling fastHasAttribute() then fastGetAttribute(), call fastGetAttribute() directly and check if the returned value is nullAtom. fastHasAttribute() and fastGetAttribute() do exactly the same thing internally and the only difference is the return type. The attribute lookup is a linear search and thus it is a good idea to avoid doing it twice. R=adamk, eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168318

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	Source/core/html/HTMLElement.cpp	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/184613003/1

6 years, 9 months ago (2014-03-03 17:03:00 UTC) #4

Message was sent while issue was closed.

Change committed as 168318

Expand Messages | Collapse Messages