Fix missing/broken ds.Stop handling in raw DS.

Fix missing/broken ds.Stop handling in raw DS.

Several places were missed when patching "ds.Stop" to being correctly filtred
at the top interface rather than the raw interface.

At the top-level, GetAll and Count both did not filter the Stop error.
At the filter level, several filters were ignoring error values from
their callbacks.

Also fixes an issue in count filter where the ds.Stop error was being
incorrectly filtered at the RawInterface level.

Add datastore iterating query filter.

R=iannucci@chromium.org
BUG=

Committed: https://github.com/luci/gae/commit/f2a2648b0e74fb73c9443669852606328952a017

[dnj, 2016-04-01 02:41:40]

PTAL

[iannucci, 2016-04-01 02:45:42]

looks ok, but needs rebase I think

https://chromiumcodereview.appspot.com/1846123002/diff/1/filter/count/count.go
File filter/count/count.go (right):

https://chromiumcodereview.appspot.com/1846123002/diff/1/filter/count/count.g...
filter/count/count.go:70: func (e *Entry) upFilter(err, filter error, filterMore
...error) error {
can't this just be upFilterStop? Does it ever filter anything else?

https://chromiumcodereview.appspot.com/1846123002/diff/1/filter/dsQueryBatch/...
File filter/dsQueryBatch/context.go (right):

https://chromiumcodereview.appspot.com/1846123002/diff/1/filter/dsQueryBatch/...
filter/dsQueryBatch/context.go:1: // Copyright 2015 The Chromium Authors. All
rights reserved.
er... rebase?

[dnj, 2016-04-01 21:41:05]

https://chromiumcodereview.appspot.com/1846123002/diff/1/filter/count/count.go
File filter/count/count.go (right):

https://chromiumcodereview.appspot.com/1846123002/diff/1/filter/count/count.g...
filter/count/count.go:70: func (e *Entry) upFilter(err, filter error, filterMore
...error) error {
On 2016/04/01 02:45:42, iannucci wrote:
> can't this just be upFilterStop? Does it ever filter anything else?

Done.

[iannucci, 2016-04-01 21:44:43]

lgtm

[dnj, 2016-04-01 21:45:26]

The CQ bit was checked by dnj@chromium.org

[commit-bot: I haz the power, 2016-04-01 21:45:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1846123002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1846123002/40001

[commit-bot: I haz the power, 2016-04-01 21:53:49]

Description was changed from

==========
Fix missing/broken ds.Stop handling in raw DS.

Several places were missed when patching "ds.Stop" to being correctly filtred
at the top interface rather than the raw interface.

At the top-level, GetAll and Count both did not filter the Stop error.
At the filter level, several filters were ignoring error values from
their callbacks.

Also fixes an issue in count filter where the ds.Stop error was being
incorrectly filtered at the RawInterface level.

Add datastore iterating query filter.

R=iannucci@chromium.org
BUG=
==========

to

==========
Fix missing/broken ds.Stop handling in raw DS.

Several places were missed when patching "ds.Stop" to being correctly filtred
at the top interface rather than the raw interface.

At the top-level, GetAll and Count both did not filter the Stop error.
At the filter level, several filters were ignoring error values from
their callbacks.

Also fixes an issue in count filter where the ds.Stop error was being
incorrectly filtered at the RawInterface level.

Add datastore iterating query filter.

R=iannucci@chromium.org
BUG=

Committed:
https://github.com/luci/gae/commit/f2a2648b0e74fb73c9443669852606328952a017
==========

[commit-bot: I haz the power, 2016-04-01 21:53:50]

Committed patchset #3 (id:40001) as
https://github.com/luci/gae/commit/f2a2648b0e74fb73c9443669852606328952a017