🍱 Pass build scripts .interface.jar directly rather than --use-ijars

Pass build scripts .interface.jar directly rather than --use-ijars

Also removes logic to create .jar manifests, which was unused.

BUG=none

Committed: https://crrev.com/7aa96bc34a83f1310644658b56f73122dae11452
Cr-Commit-Position: refs/heads/master@{#385095}

[agrieve, 2016-04-01 00:36:32]

Description was changed from

==========
Pass build scripts .interface.jar directly rather than --use-ijars

Also removes logic to create .jar manifests, which was unused.

BUG=none
==========

to

==========
Pass build scripts .interface.jar directly rather than --use-ijars

Also removes logic to create .jar manifests, which was unused.

BUG=none
==========

[agrieve, 2016-04-01 00:36:32]

agrieve@chromium.org changed reviewers:
+ jbudorick@chromium.org

[agrieve, 2016-04-01 00:44:33]

On 2016/04/01 00:36:32, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:jbudorick@chromium.org

[jbudorick, 2016-04-01 04:37:43]

The ijar parts seem reasonable.

https://codereview.chromium.org/1846113002/diff/1/build/android/gyp/javac.py
File build/android/gyp/javac.py (left):

https://codereview.chromium.org/1846113002/diff/1/build/android/gyp/javac.py#...
build/android/gyp/javac.py:342: parser.add_option(
Does removing this break junit tests on gyp?
https://code.google.com/p/chromium/codesearch#chromium/src/build/host_jar.gyp...

[agrieve, 2016-04-01 17:39:03]

https://codereview.chromium.org/1846113002/diff/1/build/android/gyp/javac.py
File build/android/gyp/javac.py (left):

https://codereview.chromium.org/1846113002/diff/1/build/android/gyp/javac.py#...
build/android/gyp/javac.py:342: parser.add_option(
On 2016/04/01 04:37:43, jbudorick wrote:
> Does removing this break junit tests on gyp?
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/host_jar.gyp...

Hrm, my codesearch skills failed me on this one I think. That said, they still
don't look to be used, so just deleted them from .gypi

[agrieve, 2016-04-01 17:39:09]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 17:39:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1846113002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1846113002/20001

[commit-bot: I haz the power, 2016-04-01 19:36:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 19:36:26]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jbudorick, 2016-04-04 21:23:37]

lgtm

[agrieve, 2016-04-05 01:53:04]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-04-05 01:53:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1846113002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1846113002/20001

[commit-bot: I haz the power, 2016-04-05 03:04:14]

Description was changed from

==========
Pass build scripts .interface.jar directly rather than --use-ijars

Also removes logic to create .jar manifests, which was unused.

BUG=none
==========

to

==========
Pass build scripts .interface.jar directly rather than --use-ijars

Also removes logic to create .jar manifests, which was unused.

BUG=none
==========

[commit-bot: I haz the power, 2016-04-05 03:04:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-05 03:05:42]

Description was changed from

==========
Pass build scripts .interface.jar directly rather than --use-ijars

Also removes logic to create .jar manifests, which was unused.

BUG=none
==========

to

==========
Pass build scripts .interface.jar directly rather than --use-ijars

Also removes logic to create .jar manifests, which was unused.

BUG=none

Committed: https://crrev.com/7aa96bc34a83f1310644658b56f73122dae11452
Cr-Commit-Position: refs/heads/master@{#385095}
==========

[commit-bot: I haz the power, 2016-04-05 03:05:43]

Patchset 2 (id:??) landed as
https://crrev.com/7aa96bc34a83f1310644658b56f73122dae11452
Cr-Commit-Position: refs/heads/master@{#385095}