fpdfsdk/fpdfppo.cpp - Issue 1846083002: Remove CFX_{Byte,Wide}String::Equal in favor of "==".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdfppo.cpp

Issue 1846083002: Remove CFX_{Byte,Wide}String::Equal in favor of "==". (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fpdfppo.cpp

diff --git a/fpdfsdk/fpdfppo.cpp b/fpdfsdk/fpdfppo.cpp

index 94fa6bae84fe0398f19b3d1a8c5430fb6af544a9..f7855c9e8cab6678743e857fba475c5be02a7d3f 100644

--- a/fpdfsdk/fpdfppo.cpp

+++ b/fpdfsdk/fpdfppo.cpp

@@ -65,7 +65,7 @@ FX_BOOL CPDF_PageOrganizer::PDFDocInit(CPDF_Document* pDestPDFDoc,

// Set type

CFX_ByteString cbRootType = pNewRoot->GetStringBy("Type", "");

- if (cbRootType.Equal("")) {

+ if (cbRootType == "") {

Lei Zhang 2016/04/01 01:02:36 Replace with IsEmpty()?

Tom Sepez 2016/04/01 17:06:12 Done.

pNewRoot->SetAt("Type", new CPDF_Name("Catalog"));

}

@@ -79,7 +79,7 @@ FX_BOOL CPDF_PageOrganizer::PDFDocInit(CPDF_Document* pDestPDFDoc,

}

CFX_ByteString cbPageType = pNewPages->GetStringBy("Type", "");

- if (cbPageType.Equal("")) {

+ if (cbPageType == "") {

pNewPages->SetAt("Type", new CPDF_Name("Pages"));

}