chrome/browser/ui/global_error/global_error.cc - Issue 1846033002: Switch GlobalErrorBubbleView to a BubbleDialogDelegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/global_error/global_error.cc

Issue 1846033002: Switch GlobalErrorBubbleView to a BubbleDialogDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix button action Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/global_error/global_error.h ('K') | « chrome/browser/ui/global_error/global_error.h ('k') | chrome/browser/ui/views/global_error_bubble_view.h » ('j') | chrome/browser/ui/views/global_error_bubble_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/global_error/global_error.cc

diff --git a/chrome/browser/ui/global_error/global_error.cc b/chrome/browser/ui/global_error/global_error.cc

index 87645c41835e7c1e47c888cba51f897b9e47c6d3..fd99a25d08d54f68edd1956fe384c75c1950627b 100644

--- a/chrome/browser/ui/global_error/global_error.cc

+++ b/chrome/browser/ui/global_error/global_error.cc

@@ -73,10 +73,6 @@ bool GlobalErrorWithStandardBubble::ShouldShowCloseButton() const {

return false;

}

-bool GlobalErrorWithStandardBubble::ShouldAddElevationIconToAcceptButton() {

- return false;

void GlobalErrorWithStandardBubble::BubbleViewDidClose(Browser* browser) {

DCHECK(browser);

bubble_view_ = NULL;