Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Side by Side Diff: chrome/browser/ui/global_error/global_error.h

Issue 1846033002: Switch GlobalErrorBubbleView to a BubbleDialogDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix button action Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_GLOBAL_ERROR_GLOBAL_ERROR_H_ 5 #ifndef CHROME_BROWSER_UI_GLOBAL_ERROR_GLOBAL_ERROR_H_
6 #define CHROME_BROWSER_UI_GLOBAL_ERROR_GLOBAL_ERROR_H_ 6 #define CHROME_BROWSER_UI_GLOBAL_ERROR_GLOBAL_ERROR_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 // Returns the title for the bubble view. 72 // Returns the title for the bubble view.
73 virtual base::string16 GetBubbleViewTitle() = 0; 73 virtual base::string16 GetBubbleViewTitle() = 0;
74 // Returns the messages for the bubble view, one per line. Multiple messages 74 // Returns the messages for the bubble view, one per line. Multiple messages
75 // are only supported on Views. 75 // are only supported on Views.
76 // TODO(yoz): Add multi-line support for GTK and Cocoa. 76 // TODO(yoz): Add multi-line support for GTK and Cocoa.
77 virtual std::vector<base::string16> GetBubbleViewMessages() = 0; 77 virtual std::vector<base::string16> GetBubbleViewMessages() = 0;
78 // Returns the accept button label for the bubble view. 78 // Returns the accept button label for the bubble view.
79 virtual base::string16 GetBubbleViewAcceptButtonLabel() = 0; 79 virtual base::string16 GetBubbleViewAcceptButtonLabel() = 0;
80 // Returns true if the bubble needs a close(x) button. 80 // Returns true if the bubble needs a close(x) button.
81 virtual bool ShouldShowCloseButton() const; 81 virtual bool ShouldShowCloseButton() const;
82 // Returns true if the accept button needs elevation icon (only effective
83 // on Windows platform).
84 virtual bool ShouldAddElevationIconToAcceptButton();
msw 2016/03/31 22:37:18 Isn't this used by chrome/browser/safe_browsing/sr
Evan Stade 2016/04/01 20:58:15 ah crud. I guess it slipped my mind that code sear
85 // Returns the cancel button label for the bubble view. To hide the cancel 82 // Returns the cancel button label for the bubble view. To hide the cancel
86 // button return an empty string. 83 // button return an empty string.
87 virtual base::string16 GetBubbleViewCancelButtonLabel() = 0; 84 virtual base::string16 GetBubbleViewCancelButtonLabel() = 0;
88 // Called when the bubble view is closed. |browser| is the Browser that the 85 // Called when the bubble view is closed. |browser| is the Browser that the
89 // bubble view was shown on. 86 // bubble view was shown on.
90 void BubbleViewDidClose(Browser* browser); 87 void BubbleViewDidClose(Browser* browser);
91 // Notifies subclasses that the bubble view is closed. |browser| is the 88 // Notifies subclasses that the bubble view is closed. |browser| is the
92 // Browser that the bubble view was shown on. 89 // Browser that the bubble view was shown on.
93 virtual void OnBubbleViewDidClose(Browser* browser) = 0; 90 virtual void OnBubbleViewDidClose(Browser* browser) = 0;
94 // Called when the user clicks on the accept button. |browser| is the 91 // Called when the user clicks on the accept button. |browser| is the
(...skipping 14 matching lines...) Expand all
109 GlobalErrorBubbleViewBase* GetBubbleView() override; 106 GlobalErrorBubbleViewBase* GetBubbleView() override;
110 107
111 private: 108 private:
112 bool has_shown_bubble_view_; 109 bool has_shown_bubble_view_;
113 GlobalErrorBubbleViewBase* bubble_view_; 110 GlobalErrorBubbleViewBase* bubble_view_;
114 111
115 DISALLOW_COPY_AND_ASSIGN(GlobalErrorWithStandardBubble); 112 DISALLOW_COPY_AND_ASSIGN(GlobalErrorWithStandardBubble);
116 }; 113 };
117 114
118 #endif // CHROME_BROWSER_UI_GLOBAL_ERROR_GLOBAL_ERROR_H_ 115 #endif // CHROME_BROWSER_UI_GLOBAL_ERROR_GLOBAL_ERROR_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/global_error/global_error.cc » ('j') | chrome/browser/ui/views/global_error_bubble_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698