Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 1846023003: Don't clamp scroll positions until the end of all layouts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: back to original approach for landing, will do real fix separately Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 841 matching lines...) Expand 10 before | Expand all | Expand 10 after
852 void LayoutBlock::startDelayUpdateScrollInfo() 852 void LayoutBlock::startDelayUpdateScrollInfo()
853 { 853 {
854 if (gDelayUpdateScrollInfo == 0) { 854 if (gDelayUpdateScrollInfo == 0) {
855 ASSERT(!gDelayedUpdateScrollInfoSet); 855 ASSERT(!gDelayedUpdateScrollInfoSet);
856 gDelayedUpdateScrollInfoSet = new DelayedUpdateScrollInfoSet; 856 gDelayedUpdateScrollInfoSet = new DelayedUpdateScrollInfoSet;
857 } 857 }
858 ASSERT(gDelayedUpdateScrollInfoSet); 858 ASSERT(gDelayedUpdateScrollInfoSet);
859 ++gDelayUpdateScrollInfo; 859 ++gDelayUpdateScrollInfo;
860 } 860 }
861 861
862 bool LayoutBlock::finishDelayUpdateScrollInfo(SubtreeLayoutScope* layoutScope) 862 bool LayoutBlock::finishDelayUpdateScrollInfo(SubtreeLayoutScope* layoutScope, S crollPositionMap* scrollMap)
863 { 863 {
864 bool childrenMarkedForRelayout = false; 864 bool childrenMarkedForRelayout = false;
865 865
866 --gDelayUpdateScrollInfo; 866 --gDelayUpdateScrollInfo;
867 ASSERT(gDelayUpdateScrollInfo >= 0); 867 ASSERT(gDelayUpdateScrollInfo >= 0);
868 if (gDelayUpdateScrollInfo == 0) { 868 if (gDelayUpdateScrollInfo == 0) {
869 ASSERT(gDelayedUpdateScrollInfoSet); 869 ASSERT(gDelayedUpdateScrollInfoSet);
870 870
871 OwnPtr<DelayedUpdateScrollInfoSet> infoSet(adoptPtr(gDelayedUpdateScroll InfoSet)); 871 OwnPtr<DelayedUpdateScrollInfoSet> infoSet(adoptPtr(gDelayedUpdateScroll InfoSet));
872 gDelayedUpdateScrollInfoSet = nullptr; 872 gDelayedUpdateScrollInfoSet = nullptr;
873 873
874 for (auto* block : *infoSet) { 874 for (auto* block : *infoSet) {
875 if (block->hasOverflowClip()) { 875 if (block->hasOverflowClip()) {
876 childrenMarkedForRelayout |= block->layer()->getScrollableArea() ->updateAfterLayout(layoutScope); 876 PaintLayerScrollableArea* scrollableArea = block->layer()->getSc rollableArea();
877 if (scrollMap)
878 scrollMap->add(scrollableArea, scrollableArea->scrollPositio nDouble());
879 childrenMarkedForRelayout |= scrollableArea->updateAfterLayout(l ayoutScope);
877 } 880 }
878 } 881 }
879 } 882 }
880 return childrenMarkedForRelayout; 883 return childrenMarkedForRelayout;
881 } 884 }
882 885
883 void LayoutBlock::updateScrollInfoAfterLayout() 886 void LayoutBlock::updateScrollInfoAfterLayout()
884 { 887 {
885 if (hasOverflowClip()) { 888 if (hasOverflowClip()) {
886 if (style()->isFlippedBlocksWritingMode()) { 889 if (style()->isFlippedBlocksWritingMode()) {
(...skipping 1979 matching lines...) Expand 10 before | Expand all | Expand 10 after
2866 void LayoutBlock::showLineTreeAndMark(const InlineBox* markedBox1, const char* m arkedLabel1, const InlineBox* markedBox2, const char* markedLabel2, const Layout Object* obj) const 2869 void LayoutBlock::showLineTreeAndMark(const InlineBox* markedBox1, const char* m arkedLabel1, const InlineBox* markedBox2, const char* markedLabel2, const Layout Object* obj) const
2867 { 2870 {
2868 showLayoutObject(); 2871 showLayoutObject();
2869 for (const RootInlineBox* root = firstRootBox(); root; root = root->nextRoot Box()) 2872 for (const RootInlineBox* root = firstRootBox(); root; root = root->nextRoot Box())
2870 root->showLineTreeAndMark(markedBox1, markedLabel1, markedBox2, markedLa bel2, obj, 1); 2873 root->showLineTreeAndMark(markedBox1, markedLabel1, markedBox2, markedLa bel2, obj, 1);
2871 } 2874 }
2872 2875
2873 #endif 2876 #endif
2874 2877
2875 } // namespace blink 2878 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698