Issue 18460003: Move url_request_context from remoting/host/ to remoting/base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18460003: Move url_request_context from remoting/host/ to remoting/base/ (Closed)

Created:
7 years, 5 months ago by solb

Modified:
7 years, 5 months ago

Reviewers:
Sergey Ulanov, garykac

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Move url_request_context from remoting/host/ to remoting/base/ This will make it easy for future non--Web app client implementations to make use of this class. The vlog_net_log class also had to be relocated. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210235

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -304 lines)			Patch
A +	remoting/base/url_request_context.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	remoting/base/url_request_context.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	remoting/base/vlog_net_log.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	remoting/base/vlog_net_log.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/chromoting_host_context.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/setup/host_starter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/setup/start_host.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/setup/win/host_configurer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
D	remoting/host/url_request_context.h	View	1 chunk	+0 lines, -64 lines	0 comments	Download
D	remoting/host/url_request_context.cc	View	1 chunk	+0 lines, -139 lines	0 comments	Download
D	remoting/host/vlog_net_log.h	View	1 chunk	+0 lines, -32 lines	0 comments	Download
D	remoting/host/vlog_net_log.cc	View	1 chunk	+0 lines, -52 lines	0 comments	Download
M	remoting/remoting.gyp	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/solb@chromium.org/18460003/1

7 years, 5 months ago (2013-07-04 18:01:42 UTC) #3

Message was sent while issue was closed.

Change committed as 210235

Expand Messages | Collapse Messages