Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1845923002:
4 spaces for tab size in view source. (Closed)
|
Created:
4 years, 8 months ago by Jonathan Garbee Modified:
4 years, 8 months ago CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description4 spaces for tab size in view source.
BUG=598632
Committed: https://crrev.com/0a353ab8c75241ef2e1101bcf5e2e23ae32a1fbf
Cr-Commit-Position: refs/heads/master@{#384906}
Patch Set 1 #
Total comments: 1
Patch Set 2 : 2 to 4 spaces #Messages
Total messages: 18 (7 generated)
jonathan.garbee@chromium.org changed reviewers: + inferno@chromium.org, leviw@chromium.org
PTAL
leviw@chromium.org changed reviewers: + pfeldman@chromium.org
I don't have strong opinions about this, and the patch seems fine on the face of it. Perhaps pfeldman can comment/suggest a good reviewer for the UI change. If so I'm happy to rubber stamp this thing.
https://codereview.chromium.org/1845923002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/css/view-source.css (right): https://codereview.chromium.org/1845923002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/css/view-source.css:37: tab-size: 2; Lets start with going from 8 to 4.
On 2016/03/31 at 20:23:43, pfeldman wrote: > https://codereview.chromium.org/1845923002/diff/1/third_party/WebKit/Source/c... > File third_party/WebKit/Source/core/css/view-source.css (right): > > https://codereview.chromium.org/1845923002/diff/1/third_party/WebKit/Source/c... > third_party/WebKit/Source/core/css/view-source.css:37: tab-size: 2; > Lets start with going from 8 to 4. done
Description was changed from ========== 2 spaces for tab size in view source. BUG=598632 ========== to ========== 4 spaces for tab size in view source. BUG=598632 ==========
lgtm
RS-LGTM
The CQ bit was checked by jonathan.garbee@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845923002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...) linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by jonathan.garbee@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845923002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== 4 spaces for tab size in view source. BUG=598632 ========== to ========== 4 spaces for tab size in view source. BUG=598632 Committed: https://crrev.com/0a353ab8c75241ef2e1101bcf5e2e23ae32a1fbf Cr-Commit-Position: refs/heads/master@{#384906} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/0a353ab8c75241ef2e1101bcf5e2e23ae32a1fbf Cr-Commit-Position: refs/heads/master@{#384906} |
