Clean up Cl flag refrences in the bitcode parser.

Clean up Cl flag refrences in the bitcode parser.

The code previously had to navigate through 1 (or more) indirect
pointers to find the CL flags. Since CL flags are a static field in
the global context, simplify these references. Note: I have added
member functions to do this (where appropriate) so that fixing code
could be easy if we choose to move where the command line flags are
stored.

BUG=None
R=eholk@chromium.org, stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=23866e7b1575b39ed8db8b2c26eaad68c0d83cc4

[Karl, 2016-03-31 20:55:29]

Description was changed from

==========
Clean up Cl flag refrences in the bitcode parser.

The code previously had to navigate through 1 (or more) indirect
pointers to find the CL flags. Since CL flags are a static field in
the global context, simplify these references. Note: I have added
member functions to do this (where appropriate) so that fixing code
could be easy if we choose to move where the command line flags are
stored.

BUG=None
==========

to

==========
Clean up Cl flag refrences in the bitcode parser.

The code previously had to navigate through 1 (or more) indirect
pointers to find the CL flags. Since CL flags are a static field in
the global context, simplify these references. Note: I have added
member functions to do this (where appropriate) so that fixing code
could be easy if we choose to move where the command line flags are
stored.

BUG=None
==========

[Karl, 2016-03-31 20:55:29]

kschimpf@google.com changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, sehr@chromium.org, stichnot@chromium.org

[Eric Holk, 2016-03-31 21:00:47]

lgtm

[Jim Stichnoth, 2016-03-31 21:02:31]

LGTM.

If you're feeling a bit more ambitious, change all instances in the code base to
GlobalContext::getFlags().

(I personally would approach this by temporarily renaming getFlags() to
getFlagsXXX(), "fixing" the compiler errors, and finally renaming back to the
original.)

https://codereview.chromium.org/1845913003/diff/1/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/1845913003/diff/1/src/PNaClTranslator.cpp#new...
src/PNaClTranslator.cpp:240: const Ice::ClFlags &getFlags() const {
Make this static?

[Karl, 2016-03-31 21:39:12]

Description was changed from

==========
Clean up Cl flag refrences in the bitcode parser.

The code previously had to navigate through 1 (or more) indirect
pointers to find the CL flags. Since CL flags are a static field in
the global context, simplify these references. Note: I have added
member functions to do this (where appropriate) so that fixing code
could be easy if we choose to move where the command line flags are
stored.

BUG=None
==========

to

==========
Clean up Cl flag refrences in the bitcode parser.

The code previously had to navigate through 1 (or more) indirect
pointers to find the CL flags. Since CL flags are a static field in
the global context, simplify these references. Note: I have added
member functions to do this (where appropriate) so that fixing code
could be easy if we choose to move where the command line flags are
stored.

BUG=None
R=eholk@chromium.org, stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Karl, 2016-03-31 21:39:13]

Committed patchset #2 (id:20001) manually as
23866e7b1575b39ed8db8b2c26eaad68c0d83cc4 (presubmit successful).

[Karl, 2016-03-31 21:39:48]

Will work on fixing the rest of the calls to getFlags() in another CL.

https://codereview.chromium.org/1845913003/diff/1/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/1845913003/diff/1/src/PNaClTranslator.cpp#new...
src/PNaClTranslator.cpp:240: const Ice::ClFlags &getFlags() const {
On 2016/03/31 21:02:31, stichnot wrote:
> Make this static?

Done.