Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1845893002: [ChromeOS] Add Swapped Memory to TaskManager (Closed)

Created:
4 years, 8 months ago by oshima
Modified:
4 years, 8 months ago
Reviewers:
afakhry
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ChromeOS] Add Swapped Memory to TaskManager BUG=None Committed: https://crrev.com/b3a3c78b4800783f45e0e23261c7275ee095e9ad Cr-Commit-Position: refs/heads/master@{#385127}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -10 lines) Patch
M chrome/app/generated_resources.grd View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/task_management/sampling/task_group.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/task_management/sampling/task_group_sampler.h View 1 chunk +8 lines, -9 lines 0 comments Download
M chrome/browser/task_management/sampling/task_group_sampler.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/task_management/sampling/task_manager_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/task_management/sampling/task_manager_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/task_management/task_manager_interface.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/task_management/test_task_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/task_management/test_task_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/task_manager/task_manager_columns.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/task_manager/task_manager_table_model.cc View 4 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 31 (18 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845893002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845893002/60001
4 years, 8 months ago (2016-04-01 04:36:11 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/189502) linux_chromium_gn_chromeos_rel on ...
4 years, 8 months ago (2016-04-01 04:54:48 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845893002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845893002/100001
4 years, 8 months ago (2016-04-01 22:43:29 UTC) #6
oshima
4 years, 8 months ago (2016-04-01 23:50:10 UTC) #15
oshima
4 years, 8 months ago (2016-04-01 23:50:16 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-02 00:05:51 UTC) #18
afakhry
lgtm with one nit. Thanks for adding this. https://codereview.chromium.org/1845893002/diff/100001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/1845893002/diff/100001/chrome/app/generated_resources.grd#newcode3405 chrome/app/generated_resources.grd:3405: + ...
4 years, 8 months ago (2016-04-04 18:32:53 UTC) #19
oshima
https://codereview.chromium.org/1845893002/diff/100001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/1845893002/diff/100001/chrome/app/generated_resources.grd#newcode3405 chrome/app/generated_resources.grd:3405: + Swapped memory On 2016/04/04 18:32:52, afakhry wrote: > ...
4 years, 8 months ago (2016-04-05 01:03:02 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845893002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845893002/120001
4 years, 8 months ago (2016-04-05 01:03:39 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_TIMED_OUT, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/48234)
4 years, 8 months ago (2016-04-05 07:14:04 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845893002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845893002/120001
4 years, 8 months ago (2016-04-05 07:22:15 UTC) #27
commit-bot: I haz the power
Committed patchset #2 (id:120001)
4 years, 8 months ago (2016-04-05 08:00:31 UTC) #29
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 08:02:01 UTC) #31
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b3a3c78b4800783f45e0e23261c7275ee095e9ad
Cr-Commit-Position: refs/heads/master@{#385127}

Powered by Google App Engine
This is Rietveld 408576698