Split the footer in ClearBrowsingDataPreferences into two paragraphs

chrome/android/java/res/layout/text_message_with_link_and_icon_preference.xml

Index: chrome/android/java/res/layout/text_message_with_link_and_icon_preference.xml
diff --git a/chrome/android/java/res/layout/text_message_with_link_and_icon_preference.xml b/chrome/android/java/res/layout/text_message_with_link_and_icon_preference.xml
new file mode 100644
index 0000000000000000000000000000000000000000..3c3426d0b0bda85e9a9f39ae5965b31e588d8806
--- /dev/null
+++ b/chrome/android/java/res/layout/text_message_with_link_and_icon_preference.xml
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2016 The Chromium Authors. All rights reserved.
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file. -->
+
+<!-- Layout used by the TextMessageWithLinkAndIconPreference. -->
+
+<LinearLayout

[newt (away), 2016/04/02 01:24:03]

Use a RelativeLayout here to reduce nesting (see
http://developer.android.com/training/improving-layouts/optimizing-layout.html)

[msramek, 2016/04/04 16:23:12]

Done.

+    xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:chrome="http://schemas.android.com/apk/res-auto"

[newt (away), 2016/04/02 01:24:03]

chrome namespace isn't needed

[msramek, 2016/04/04 16:23:12]

Done.

+    style="@style/PreferenceLayout"
+    android:layout_width="match_parent"
+    android:layout_height="wrap_content"
+    android:gravity="top">

[newt (away), 2016/04/02 01:24:03]

not needed / redundant, since the ImageView specifies layout_gravity="top"

[msramek, 2016/04/04 16:23:12]

Done.

+
+    <ImageView
+        android:id="@+android:id/icon"
+        android:contentDescription="@null"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:layout_gravity="top" />
+
+    <LinearLayout
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:layout_marginStart="16dp"
+        android:orientation="vertical">
+
+        <TextView android:id="@+android:id/title"

[newt (away), 2016/04/02 01:24:03]

nit: put android:id on the next line

[msramek, 2016/04/04 16:23:12]

Done.

+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:textAppearance="?android:attr/textAppearanceLarge" />
+
+        <TextView android:id="@+android:id/summary"

[newt (away), 2016/04/02 01:24:03]

To support accessibility users, use TextViewWithClickableSpans here.

[msramek, 2016/04/04 16:23:12]

Done.

+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:textAppearance="?android:attr/textAppearanceSmall"

[newt (away), 2016/04/02 01:24:03]

Instead of specifying textAppearance and textColor, use
style="@style/PreferenceTitle" and style="@style/PreferenceSummary". Those
styles vary according to API level, so these views will look correct on pre-L
(pre-Material) devices too.

[msramek, 2016/04/04 16:23:12]

Done.

+            android:textColor="?android:attr/textColorSecondary" />
+
+    </LinearLayout>
+
+</LinearLayout>