Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1845843003: Fix comment for GlobalHandles::MarkIndependent (Closed)

Created:
4 years, 8 months ago by Marcel Hlopko
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix comment for GlobalHandles::MarkIndependent BUG= LOG=no Committed: https://crrev.com/da934aba4a6a2ca62fb840dcd01489269958e11a Cr-Commit-Position: refs/heads/master@{#35171}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/global-handles.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Marcel Hlopko
Tiny tiny comment fix
4 years, 8 months ago (2016-03-31 13:44:02 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-03-31 15:30:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845843003/1
4 years, 8 months ago (2016-03-31 15:35:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 15:58:59 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 15:59:52 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/da934aba4a6a2ca62fb840dcd01489269958e11a
Cr-Commit-Position: refs/heads/master@{#35171}

Powered by Google App Engine
This is Rietveld 408576698