Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1101)

Issue 1845833002: [d8] remove utility context. (Closed)

Created:
4 years, 8 months ago by Yang
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[d8] remove utility context. We only use it to store the Stringify function to format REPL output. This is overkill and introduces issues with security tokens. R=jochen@chromium.org BUG= Committed: https://crrev.com/18c80bc8798d2e2c02a7d9b57eb429e20ff789df Cr-Commit-Position: refs/heads/master@{#35158}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -73 lines) Patch
M src/d8.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/d8.cc View 7 chunks +36 lines, -71 lines 0 comments Download
M src/d8.js View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 8 months ago (2016-03-31 08:19:53 UTC) #1
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-03-31 08:36:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845833002/1
4 years, 8 months ago (2016-03-31 09:55:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 10:16:48 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 10:18:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18c80bc8798d2e2c02a7d9b57eb429e20ff789df
Cr-Commit-Position: refs/heads/master@{#35158}

Powered by Google App Engine
This is Rietveld 408576698