Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 184583004: Revert of Chrome power profiler service (Closed)

Created:
6 years, 9 months ago by erikwright (departed)
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Revert of Chrome power profiler service (https://codereview.chromium.org/140583003/) Reason for revert: Appears to have caused a memory leak. http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%282%29/builds/23519/steps/content_unittests/logs/AvailableService Indirect leak of 176 byte(s) in 1 object(s) allocated from: #0 0x49c001 in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:54 #1 0xf42228 in content::PowerProfilerServiceTest::ServiceStartTest() content/browser/power_profiler/power_profiler_service_unittest.cc:85 #2 0xf4212d in content::PowerProfilerServiceTest_AvailableService_Test::TestBody() content/browser/power_profiler/power_profiler_service_unittest.cc:138 #3 0x2d3587a in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #4 0x2d3587a in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #5 0x2d379ca in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #6 0x2d38793 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #7 0x2d4984a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #8 0x2d48e30 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #9 0x2d48e30 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #10 0x2cc09cc in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #11 0x2cc09cc in base::TestSuite::Run() base/test/test_suite.cc:213 #12 0x2cb4041 in Run base/callback.h:401 #13 0x2cb4041 in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494 #14 0x195d8ce in main content/test/run_all_unittests.cc:14 #15 0x7f515353d76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > This CL implemented part of chrome power profiler, including the service, data provider and observer base. > > BUG=337138 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254116 TBR=qsr@chromium.org,tonyg@chromium.org,pfeldman@chromium.org,darin@chromium.org,jam@chromium.org,jeremy@chromium.org,pan.deng@intel.com NOTREECHECKS=true NOTRY=true BUG=337138 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254146

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -592 lines) Patch
D content/browser/devtools/devtools_power_handler.h View 1 chunk +0 lines, -36 lines 0 comments Download
D content/browser/devtools/devtools_power_handler.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D content/browser/power_profiler/power_data_provider.h View 1 chunk +0 lines, -31 lines 0 comments Download
D content/browser/power_profiler/power_data_provider_dummy.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D content/browser/power_profiler/power_event.h View 1 chunk +0 lines, -42 lines 0 comments Download
D content/browser/power_profiler/power_event.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D content/browser/power_profiler/power_profiler_observer.h View 1 chunk +0 lines, -33 lines 0 comments Download
D content/browser/power_profiler/power_profiler_service.h View 1 chunk +0 lines, -76 lines 0 comments Download
D content/browser/power_profiler/power_profiler_service.cc View 1 chunk +0 lines, -118 lines 0 comments Download
D content/browser/power_profiler/power_profiler_service_unittest.cc View 1 chunk +0 lines, -144 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +0 lines, -9 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
erikwright (departed)
Created Revert of Chrome power profiler service
6 years, 9 months ago (2014-02-28 16:21:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/184583004/1
6 years, 9 months ago (2014-02-28 16:21:58 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 16:22:38 UTC) #3
Message was sent while issue was closed.
Change committed as 254146

Powered by Google App Engine
This is Rietveld 408576698