Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 18458002: Revert "roll breakpad 1182:1198" (Closed)

Created:
7 years, 5 months ago by Dirk Pranke
Modified:
7 years, 5 months ago
Reviewers:
Mark Mentovai, Nico
CC:
chromium-reviews, Lei Zhang, Mark Mentovai
Visibility:
Public.

Description

Revert "roll breakpad 1182:1198" The breakpad roll in 209552 had compile errors on the chromium.chrome builders. TBR=thakis@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209574

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Dirk Pranke
See, e.g.: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux/builds/30907/steps/compile/logs/stdio
7 years, 5 months ago (2013-07-02 01:40:37 UTC) #1
Dirk Pranke
Committed patchset #1 manually as r209574 (presubmit successful).
7 years, 5 months ago (2013-07-02 01:40:58 UTC) #2
Nico
lgtm, but please use drover to revert since it produces a better revert message (e.g. ...
7 years, 5 months ago (2013-07-02 02:01:58 UTC) #3
Dirk Pranke
On 2013/07/02 02:01:58, Nico wrote: > lgtm, but please use drover to revert since it ...
7 years, 5 months ago (2013-07-02 02:06:40 UTC) #4
Mark Mentovai
7 years, 5 months ago (2013-07-02 20:07:10 UTC) #5
Message was sent while issue was closed.
Well, I do like that you actually pasted a link to a failed build. I really like
that. A lot. Many people going through the drover automated process don’t fix up
the commit message to contain that, but it’s so helpful.

Powered by Google App Engine
This is Rietveld 408576698