Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 1845753005: PPC: Remove usages of Heap::NewSpaceStart and its external reference (Closed)

Created:
4 years, 8 months ago by MTBrandyberry
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Remove usages of Heap::NewSpaceStart and its external reference Port f2a585935fa070d2b4fb78389045d4df5253dd96 Original commit message: Replace the uses with proper page flag lookups. R=mlippautz@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=chromium:581412 LOG=N TEST=mjsunit/allocation-site-info Committed: https://crrev.com/5a09c0c0dbbde5307b8306bef8c5b8a566c0ed3c Cr-Commit-Position: refs/heads/master@{#35172}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -25 lines) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.h View 1 chunk +6 lines, -5 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/ppc/codegen-ppc.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +36 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
PTAL
4 years, 8 months ago (2016-03-31 16:10:15 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845753005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845753005/1
4 years, 8 months ago (2016-03-31 16:10:29 UTC) #3
Michael Lippautz
lgtm, thanks!
4 years, 8 months ago (2016-03-31 16:22:23 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-31 16:33:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845753005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845753005/1
4 years, 8 months ago (2016-03-31 16:44:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 16:46:25 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 16:46:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a09c0c0dbbde5307b8306bef8c5b8a566c0ed3c
Cr-Commit-Position: refs/heads/master@{#35172}

Powered by Google App Engine
This is Rietveld 408576698