Work around a bug where create_bundle() is ignoring data_deps() in iOS GN build.

Work around a bug where create_bundle() is ignoring data_deps() in iOS GN build.

It looks like create_bundle() is not checking for data_deps when it
generates its ninja rules, and as a result we don't build iossim
when we build base_unittests.app. By shifting the data_dep to the
underlying executable target, this works around the issue, but we
should probably fix the GN code generator for create_bundle() instead.

R=sdefresne@chromium.org
BUG=599203
Committed: https://crrev.com/cd03fa72212077a789679a77992529c3aa6c08fe
Cr-Commit-Position: refs/heads/master@{#384141}

[sdefresne, 2016-03-30 22:12:17]

lgtm

[Dirk Pranke, 2016-03-30 22:16:46]

Description was changed from

==========
Work around a bug where create_bundle() is ignore data_deps() in iOS GN build.

It looks like create_bundle() is not checking for data_deps when it
generates its ninja rules, and as a result we don't build iossim
when we build base_unittests.app. By shifting the data_dep to the
underlying executable target, this works around the issue, but we
should probably fix the GN code generator for create_bundle() instead.

R=sdefresne@chromium.org
BUG=599203
==========

to

==========
Work around a bug where create_bundle() is ignoring data_deps() in iOS GN build.

It looks like create_bundle() is not checking for data_deps when it
generates its ninja rules, and as a result we don't build iossim
when we build base_unittests.app. By shifting the data_dep to the
underlying executable target, this works around the issue, but we
should probably fix the GN code generator for create_bundle() instead.

R=sdefresne@chromium.org
BUG=599203
==========

[Dirk Pranke, 2016-03-30 22:17:10]

On 2016/03/30 22:12:17, sdefresne wrote:
> lgtm

Do you want me to go ahead and land this while we're waiting for the GN fix?

[Dirk Pranke, 2016-03-30 22:32:34]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2016-03-30 22:33:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845753002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845753002/1

[sdefresne, 2016-03-30 22:35:03]

Yes, I probably won't be able to land a fix for gn today.

[commit-bot: I haz the power, 2016-03-30 23:18:06]

Description was changed from

==========
Work around a bug where create_bundle() is ignoring data_deps() in iOS GN build.

It looks like create_bundle() is not checking for data_deps when it
generates its ninja rules, and as a result we don't build iossim
when we build base_unittests.app. By shifting the data_dep to the
underlying executable target, this works around the issue, but we
should probably fix the GN code generator for create_bundle() instead.

R=sdefresne@chromium.org
BUG=599203
==========

to

==========
Work around a bug where create_bundle() is ignoring data_deps() in iOS GN build.

It looks like create_bundle() is not checking for data_deps when it
generates its ninja rules, and as a result we don't build iossim
when we build base_unittests.app. By shifting the data_dep to the
underlying executable target, this works around the issue, but we
should probably fix the GN code generator for create_bundle() instead.

R=sdefresne@chromium.org
BUG=599203
==========

[commit-bot: I haz the power, 2016-03-30 23:18:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-30 23:19:14]

Description was changed from

==========
Work around a bug where create_bundle() is ignoring data_deps() in iOS GN build.

It looks like create_bundle() is not checking for data_deps when it
generates its ninja rules, and as a result we don't build iossim
when we build base_unittests.app. By shifting the data_dep to the
underlying executable target, this works around the issue, but we
should probably fix the GN code generator for create_bundle() instead.

R=sdefresne@chromium.org
BUG=599203
==========

to

==========
Work around a bug where create_bundle() is ignoring data_deps() in iOS GN build.

It looks like create_bundle() is not checking for data_deps when it
generates its ninja rules, and as a result we don't build iossim
when we build base_unittests.app. By shifting the data_dep to the
underlying executable target, this works around the issue, but we
should probably fix the GN code generator for create_bundle() instead.

R=sdefresne@chromium.org
BUG=599203

Committed: https://crrev.com/cd03fa72212077a789679a77992529c3aa6c08fe
Cr-Commit-Position: refs/heads/master@{#384141}
==========

[commit-bot: I haz the power, 2016-03-30 23:19:15]

Patchset 1 (id:??) landed as
https://crrev.com/cd03fa72212077a789679a77992529c3aa6c08fe
Cr-Commit-Position: refs/heads/master@{#384141}

[sdefresne, 2016-04-13 14:27:04]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1883843002/ by sdefresne@chromium.org.

The reason for reverting is: gn binary as been fixed and create_bundle now
causes its data_deps to be built, reverting this temporary change..