Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 1845733002: cras_audio_handler add SetOutputMono method (Closed)

Created:
4 years, 8 months ago by Qiang(Joe) Xu
Modified:
4 years, 8 months ago
Reviewers:
jennyz
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cras_audio_handler add SetOutputMono method BUG=404701 TEST=cras_audio_handler_unittest.cc Committed: https://crrev.com/745246282c486ab7a03e40def351a78b7f3958c0 Cr-Commit-Position: refs/heads/master@{#384173}

Patch Set 1 #

Total comments: 1

Patch Set 2 : channels_ -> output_channels_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -1 line) Patch
M chromeos/audio/cras_audio_handler.h View 1 3 chunks +13 lines, -0 lines 0 comments Download
M chromeos/audio/cras_audio_handler.cc View 1 4 chunks +30 lines, -0 lines 0 comments Download
M chromeos/audio/cras_audio_handler_unittest.cc View 5 chunks +31 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Qiang(Joe) Xu
based on the revision: https://chromium.googlesource.com/chromium/src.git/+/a377c049175591928ea1507ef76242d913363011
4 years, 8 months ago (2016-03-30 22:11:38 UTC) #3
jennyz
LGTM with a nit. https://codereview.chromium.org/1845733002/diff/1/chromeos/audio/cras_audio_handler.h File chromeos/audio/cras_audio_handler.h (right): https://codereview.chromium.org/1845733002/diff/1/chromeos/audio/cras_audio_handler.h#newcode421 chromeos/audio/cras_audio_handler.h:421: int32_t channels_; How about naming ...
4 years, 8 months ago (2016-03-30 23:39:26 UTC) #4
Qiang(Joe) Xu
On 2016/03/30 23:39:26, jennyz wrote: > LGTM with a nit. > > https://codereview.chromium.org/1845733002/diff/1/chromeos/audio/cras_audio_handler.h > File ...
4 years, 8 months ago (2016-03-30 23:56:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845733002/20001
4 years, 8 months ago (2016-03-30 23:56:57 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-31 01:07:36 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 01:11:07 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/745246282c486ab7a03e40def351a78b7f3958c0
Cr-Commit-Position: refs/heads/master@{#384173}

Powered by Google App Engine
This is Rietveld 408576698