Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1845723002: Allow unified desktop for 3+ displays (Closed)

Created:
4 years, 8 months ago by oshima
Modified:
4 years, 8 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow unified desktop for 3+ displays BUG=599232 Committed: https://crrev.com/99029a1c9485daea9d1c642b6a733c81f22867a4 Cr-Commit-Position: refs/heads/master@{#384140}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -123 lines) Patch
M ash/display/display_manager.cc View 1 1 chunk +115 lines, -115 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 2 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
oshima
https://codereview.chromium.org/1845723002/diff/40001/ash/display/display_manager.cc File ash/display/display_manager.cc (right): https://codereview.chromium.org/1845723002/diff/40001/ash/display/display_manager.cc#newcode1087 ash/display/display_manager.cc:1087: return; This CL just moved this change from 1083. ...
4 years, 8 months ago (2016-03-30 21:00:05 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845723002/40001
4 years, 8 months ago (2016-03-30 21:00:38 UTC) #7
stevenjb
lgtm
4 years, 8 months ago (2016-03-30 21:09:02 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/188408)
4 years, 8 months ago (2016-03-30 21:38:53 UTC) #10
oshima
PTAL https://codereview.chromium.org/1845723002/diff/40001/ash/display/display_manager.cc File ash/display/display_manager.cc (right): https://codereview.chromium.org/1845723002/diff/40001/ash/display/display_manager.cc#newcode1085 ash/display/display_manager.cc:1085: DCHECK_EQ(2u, display_info_list->size()); This check does not work when ...
4 years, 8 months ago (2016-03-30 22:01:32 UTC) #11
stevenjb
lgtm
4 years, 8 months ago (2016-03-30 22:14:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845723002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845723002/60001
4 years, 8 months ago (2016-03-30 22:19:42 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 8 months ago (2016-03-30 23:14:42 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 23:17:40 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/99029a1c9485daea9d1c642b6a733c81f22867a4
Cr-Commit-Position: refs/heads/master@{#384140}

Powered by Google App Engine
This is Rietveld 408576698