chrome/installer/util/shell_util_unittest.cc - Issue 184563006: Move WriteFile and WriteFileDescriptor from file_util to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/shell_util_unittest.cc

Issue 184563006: Move WriteFile and WriteFileDescriptor from file_util to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/importer/firefox_importer_utils_unittest.cc ('K') | « chrome/installer/util/self_cleaning_temp_dir_unittest.cc ('k') | chrome/renderer/mock_printer.cc » ('j') | chrome/service/cloud_print/printer_job_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/shell_util_unittest.cc

diff --git a/chrome/installer/util/shell_util_unittest.cc b/chrome/installer/util/shell_util_unittest.cc

index be5362285eef85fc9c4eb005c39f8a164ff5690d..03d24671bb2f959c4c78f6728b7be0b9904cb762 100644

--- a/chrome/installer/util/shell_util_unittest.cc

+++ b/chrome/installer/util/shell_util_unittest.cc

@@ -45,16 +45,16 @@ class ShellUtilShortcutTest : public testing::Test {

ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());

chrome_exe_ = temp_dir_.path().Append(installer::kChromeExe);

- EXPECT_EQ(0, file_util::WriteFile(chrome_exe_, "", 0));

+ EXPECT_EQ(0, base::WriteFile(chrome_exe_, "", 0));

manganese_exe_ = temp_dir_.path().Append(kManganeseExe);

- EXPECT_EQ(0, file_util::WriteFile(manganese_exe_, "", 0));

+ EXPECT_EQ(0, base::WriteFile(manganese_exe_, "", 0));

iron_exe_ = temp_dir_.path().Append(kIronExe);

- EXPECT_EQ(0, file_util::WriteFile(iron_exe_, "", 0));

+ EXPECT_EQ(0, base::WriteFile(iron_exe_, "", 0));

other_ico_ = temp_dir_.path().Append(kOtherIco);

- EXPECT_EQ(0, file_util::WriteFile(other_ico_, "", 0));

+ EXPECT_EQ(0, base::WriteFile(other_ico_, "", 0));

ASSERT_TRUE(fake_user_desktop_.CreateUniqueTempDir());

ASSERT_TRUE(fake_common_desktop_.CreateUniqueTempDir());

@@ -773,7 +773,7 @@ TEST_F(ShellUtilShortcutTest, DontRemoveChromeShortcutIfPointsToAnotherChrome) {

ASSERT_TRUE(other_exe_dir.CreateUniqueTempDir());

base::FilePath other_chrome_exe =

other_exe_dir.path().Append(installer::kChromeExe);

- EXPECT_EQ(0, file_util::WriteFile(other_chrome_exe, "", 0));

+ EXPECT_EQ(0, base::WriteFile(other_chrome_exe, "", 0));

test_properties_.set_target(other_chrome_exe);

ASSERT_TRUE(ShellUtil::CreateOrUpdateShortcut(