chrome/common/extensions/extension_l10n_util_unittest.cc - Issue 184563006: Move WriteFile and WriteFileDescriptor from file_util to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_l10n_util_unittest.cc

Issue 184563006: Move WriteFile and WriteFileDescriptor from file_util to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/web_applications/web_app_win.cc ('K') | « chrome/common/extensions/extension_file_util_unittest.cc ('k') | chrome/common/importer/firefox_importer_utils_unittest.cc » ('j') | chrome/common/importer/firefox_importer_utils_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension_l10n_util_unittest.cc

diff --git a/chrome/common/extensions/extension_l10n_util_unittest.cc b/chrome/common/extensions/extension_l10n_util_unittest.cc

index 74f4645b8ebbc0e89c8b22c2d04c10e97565a279..c5ed18a96ce4cecd9946f20f0b9625c02586dc5d 100644

--- a/chrome/common/extensions/extension_l10n_util_unittest.cc

+++ b/chrome/common/extensions/extension_l10n_util_unittest.cc

@@ -39,7 +39,7 @@ TEST(ExtensionL10nUtil, ValidateLocalesWithBadLocale) {

base::FilePath messages_file = locale.Append(kMessagesFilename);

std::string data = "{ \"name\":";

- ASSERT_TRUE(file_util::WriteFile(messages_file, data.c_str(), data.length()));

+ ASSERT_TRUE(base::WriteFile(messages_file, data.c_str(), data.length()));

base::DictionaryValue manifest;

manifest.SetString(keys::kDefaultLocale, "en");

@@ -94,7 +94,7 @@ TEST(ExtensionL10nUtil, GetValidLocalesWithUnsupportedLocale) {

base::FilePath locale_1 = src_path.AppendASCII("sr");

ASSERT_TRUE(base::CreateDirectory(locale_1));

std::string data("whatever");

- ASSERT_TRUE(file_util::WriteFile(

+ ASSERT_TRUE(base::WriteFile(

locale_1.Append(kMessagesFilename),

data.c_str(), data.length()));

// Unsupported locale.

@@ -187,7 +187,7 @@ TEST(ExtensionL10nUtil, LoadMessageCatalogsBadJSONFormat) {

std::string data = "{ \"name\":";

base::FilePath messages_file = locale.Append(kMessagesFilename);

- ASSERT_TRUE(file_util::WriteFile(messages_file, data.c_str(), data.length()));

+ ASSERT_TRUE(base::WriteFile(messages_file, data.c_str(), data.length()));

std::set<std::string> valid_locales;

valid_locales.insert("sr");

@@ -219,16 +219,14 @@ TEST(ExtensionL10nUtil, LoadMessageCatalogsDuplicateKeys) {

std::string data =

"{ \"name\": { \"message\": \"something\" }, "

"\"name\": { \"message\": \"something else\" } }";

- ASSERT_TRUE(

- file_util::WriteFile(locale_1.Append(kMessagesFilename),

- data.c_str(), data.length()));

+ ASSERT_TRUE(base::WriteFile(locale_1.Append(kMessagesFilename),

+ data.c_str(), data.length()));

base::FilePath locale_2 = src_path.AppendASCII("sr");

ASSERT_TRUE(base::CreateDirectory(locale_2));

- ASSERT_TRUE(

- file_util::WriteFile(locale_2.Append(kMessagesFilename),

- data.c_str(), data.length()));

+ ASSERT_TRUE(base::WriteFile(locale_2.Append(kMessagesFilename),

+ data.c_str(), data.length()));

std::set<std::string> valid_locales;

valid_locales.insert("sr");